Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-compiler): remove v6 engine support #4363

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

nolanlawson
Copy link
Collaborator

Details

Fixes #4313

Reverts #4315

The v6 engine support was always considered temporary. We don't need it anymore.

This is a compiler change, so if you are snapshotting the output of the template compiler somehow, then your snapshots will need to be updated. But that's not considered a breaking or observable change.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner July 8, 2024 18:11
@nolanlawson nolanlawson merged commit 926088b into master Jul 8, 2024
11 checks passed
@nolanlawson nolanlawson deleted the nolan/revert-v6-engine branch July 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove temporary support for v7 compiler + v6 engine
2 participants