Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine-dom): warn for insertBefore with 1 arg #4359

Merged
merged 7 commits into from
Jul 9, 2024
Merged

fix(engine-dom): warn for insertBefore with 1 arg #4359

merged 7 commits into from
Jul 9, 2024

Conversation

manoharsiriki
Copy link
Contributor

@manoharsiriki manoharsiriki commented Jul 5, 2024 •
edited by nolanlawson
Loading

Details

Partially addresses #4319

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🔬 Yes, it does include an observable change.

GUS work item

@manoharsiriki manoharsiriki requested a review from a team as a code owner July 5, 2024 13:00
@nolanlawson nolanlawson mentioned this pull request Jul 8, 2024
Closed
nolanlawson
nolanlawson requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one small suggestion.

packages/@lwc/engine-dom/src/apis/create-element.ts Outdated Show resolved Hide resolved
@nolanlawson nolanlawson mentioned this pull request Jul 9, 2024
Closed
@nolanlawson nolanlawson changed the title Fix 4319: Ensure insertBefore throws an error - Updated with logWarnOnce and added a test fix(engine-dom): warn for insertBefore with 1 arg Jul 9, 2024
@nolanlawson nolanlawson mentioned this pull request Jul 9, 2024
Closed
@nolanlawson
Copy link
Collaborator

/nucleus test

@nolanlawson nolanlawson mentioned this pull request Jul 9, 2024
Closed
@nolanlawson
Copy link
Collaborator

/nucleus test

nolanlawson
nolanlawson approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch! 🙏

@nolanlawson nolanlawson merged commit b732305 into salesforce:master Jul 9, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanlawson nolanlawson nolanlawson approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manoharsiriki @nolanlawson