Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming JaccardDistance to JaccardSimilarity #80

Merged
merged 4 commits into from
Aug 22, 2018

Conversation

tillbe
Copy link
Contributor

@tillbe tillbe commented Aug 22, 2018

Related issues
https://gitter.im/salesforce-TransmogrifAI-Issues/Issues

JaccardSimilarity was wrongly named as JaccardDistance.

Describe the proposed solution
Renaming the function to its correct name.

Describe alternatives you've considered

Additional context

@salesforce-cla
Copy link

Thanks for the contribution! It looks like @tillbe is an internal user so signing the CLA is not required. However, we need to confirm this.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@f6bc301). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #80   +/-   ##
=========================================
  Coverage          ?   85.95%           
=========================================
  Files             ?      294           
  Lines             ?     9547           
  Branches          ?      551           
=========================================
  Hits              ?     8206           
  Misses            ?     1341           
  Partials          ?        0
Impacted Files Coverage Δ
...ala/com/salesforce/op/utils/stats/JaccardSim.scala 0% <ø> (ø)
...rce/op/stages/impl/feature/JaccardSimilarity.scala 100% <100%> (ø)
...rce/op/stages/impl/feature/PhoneNumberParser.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bc301...47f097a. Read the comment docs.

@tovbinm tovbinm merged commit b9d5c31 into salesforce:master Aug 22, 2018
@tillbe tillbe deleted the tb/naming-fix branch April 23, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants