Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Wiki migration #79

Merged
merged 24 commits into from
Aug 22, 2018
Merged

Github Wiki migration #79

merged 24 commits into from
Aug 22, 2018

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Aug 22, 2018

Related issues
GitHub wiki is not versioned.

Describe the proposed solution
Migrate GitHub Wiki to https://readthedocs.org/projects/transmogrifai/ which allows us versioned documentation per release.

The docs from this PR can be viewed here - https://transmogrifai.readthedocs.io/en/mt-docs/

Describe alternatives you've considered
N/A

Additional Context
Changes:

  • Removed existing docs from repo
  • Moved GitHub Wiki pages into /docs + added configs for Sphinx

@tovbinm tovbinm requested a review from jamesward August 22, 2018 18:58
@tovbinm tovbinm changed the title Mt/docs Github Wiki migration Aug 22, 2018
@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #79 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   85.94%   85.97%   +0.03%     
==========================================
  Files         294      294              
  Lines        9547     9547              
  Branches      337      337              
==========================================
+ Hits         8205     8208       +3     
+ Misses       1342     1339       -3
Impacted Files Coverage Δ
...om/salesforce/op/utils/spark/OpSparkListener.scala 98.7% <0%> (+1.29%) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.58% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d5c31...96d8701. Read the comment docs.

Copy link
Collaborator

@leahmcguire leahmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tovbinm tovbinm merged commit 5031b09 into master Aug 22, 2018
@tovbinm tovbinm deleted the mt/docs branch August 22, 2018 22:56
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants