Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Memory Appender, Log assertions in OpSparkListner #69

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Added Memory Appender, Log assertions in OpSparkListner #69

merged 3 commits into from
Aug 17, 2018

Conversation

ajayborra
Copy link
Contributor

  • Added Memory Appender, Log assertions for OpSparkListner

@codecov
Copy link

codecov bot commented Aug 17, 2018 •
edited
Loading

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #69    +/-   ##
========================================
  Coverage   85.79%   85.79%            
========================================
  Files         298      298            
  Lines        9760     9760            
  Branches      339      535   +196     
========================================
  Hits         8374     8374            
  Misses       1386     1386

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df6b24...5f94ba2. Read the comment docs.

@ajayborra ajayborra mentioned this pull request Aug 17, 2018
Closed
tovbinm
tovbinm approved these changes Aug 17, 2018
View reviewed changes
Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you @ajayborra

@tovbinm tovbinm merged commit e5e2073 into salesforce:master Aug 17, 2018
@ajayborra ajayborra deleted the ab/memory_appender branch August 17, 2018 19:06
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
@ajayborra @tovbinm
Added Memory Appender, Log assertions in OpSparkListner (#69)
9bfc483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tovbinm tovbinm tovbinm approved these changes

@leahmcguire leahmcguire Awaiting requested review from leahmcguire leahmcguire is a code owner

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajayborra @tovbinm