Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and misspellings detected by github.com/client9/misspell #66

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Aug 17, 2018

Related issues
None.

Describe the proposed solution
This pull request fixes several typos and misspellings detected by https://github.com/client9/misspell . I've reviewed all the detections and skipped a portion of them because they are false positives.

before

$ misspell .
core/src/main/scala/com/salesforce/op/dsl/RichMapFeature.scala:247:58: "occurences" is a misspelling of "occurrences"
core/src/main/scala/com/salesforce/op/dsl/RichMapFeature.scala:376:58: "occurences" is a misspelling of "occurrences"
core/src/main/scala/com/salesforce/op/dsl/RichNumericFeature.scala:448:97: "disticnt" is a misspelling of "distinct"
core/src/main/scala/com/salesforce/op/dsl/RichSetFeature.scala:58:29: "occurances" is a misspelling of "occurrences"
core/src/main/scala/com/salesforce/op/dsl/RichSetFeature.scala:87:29: "occurances" is a misspelling of "occurrences"
core/src/main/scala/com/salesforce/op/dsl/RichTextFeature.scala:184:58: "occurences" is a misspelling of "occurrences"
core/src/main/scala/com/salesforce/op/evaluators/OpEvaluatorBase.scala:174:23: "differnt" is a misspelling of "different"
core/src/main/scala/com/salesforce/op/evaluators/OpEvaluatorBase.scala:191:23: "differnt" is a misspelling of "different"
core/src/main/scala/com/salesforce/op/evaluators/OpEvaluatorBase.scala:250:23: "differnt" is a misspelling of "different"
core/src/main/scala/com/salesforce/op/stages/impl/classification/OpMultilayerPerceptronClassifier.scala:131:46: "probablistic" is a misspelling of "probabilistic"
core/src/main/scala/com/salesforce/op/stages/impl/feature/SmartTextMapVectorizer.scala:52:8: "occurences" is a misspelling of "occurrences"
core/src/main/scala/com/salesforce/op/stages/impl/feature/SmartTextVectorizer.scala:54:8: "occurences" is a misspelling of "occurrences"
core/src/main/scala/com/salesforce/op/stages/impl/feature/Transmogrifier.scala:525:65: "occurences" is a misspelling of "occurrences"
core/src/main/scala/com/salesforce/op/stages/impl/preparators/SanityCheckerMetadata.scala:233:86: "occurance" is a misspelling of "occurrence"
core/src/test/scala/com/salesforce/op/evaluators/OpMultiClassificationEvaluatorTest.scala:99:77: "prediciton" is a misspelling of "prediction"
core/src/test/scala/com/salesforce/op/features/TransientFeatureTest.scala:53:54: "contruction" is a misspelling of "construction"
core/src/test/scala/com/salesforce/op/stages/impl/feature/TextTokenizerTest.scala:114:19: "comision" is a misspelling of "commission"
core/src/test/scala/com/salesforce/op/stages/impl/feature/TextTokenizerTest.scala:116:18: "clas" is a misspelling of "class"
core/src/test/scala/com/salesforce/op/stages/impl/insights/RecordInsightsCorrTest.scala:62:8: "predicitons" is a misspelling of "predictions"
core/src/test/scala/com/salesforce/op/stages/impl/insights/RecordInsightsCorrTest.scala:63:82: "predicitons" is a misspelling of "predictions"
core/src/test/scala/com/salesforce/op/stages/impl/insights/RecordInsightsCorrTest.scala:80:8: "predicitons" is a misspelling of "predictions"
core/src/test/scala/com/salesforce/op/stages/impl/insights/RecordInsightsCorrTest.scala:81:82: "predicitons" is a misspelling of "predictions"
docs/sources/templates/docs-index.gsp:6:12: "Documenation" is a misspelling of "Documentation"
features/src/main/scala/com/salesforce/op/stages/package.scala:78:100: "overriden" is a misspelling of "overridden"
features/src/main/scala/com/salesforce/op/utils/spark/OpVectorMetadata.scala:154:33: "overriden" is a misspelling of "overridden"
features/src/main/scala/org/apache/spark/ml/SparkMLSharedParamConstants.scala:55:35: "ouput" is a misspelling of "output"
helloworld/src/main/resources/TitanicDataset/TitanicPassengersTrainData.csv:11:8: "Sandstrom" is a misspelling of "Sandstorm"
helloworld/src/main/resources/TitanicDataset/TitanicPassengersTrainData.csv:204:9: "Youseff" is a misspelling of "Yousef"
helloworld/src/main/resources/TitanicDataset/TitanicPassengersTrainData.csv:257:31: "Maybelle" is a misspelling of "Maybelline"
helloworld/src/main/resources/TitanicDataset/TitanicPassengersTrainData.csv:395:9: "Sandstrom" is a misspelling of "Sandstorm"
templates/simple/spark.gradle:46:25: "compatability" is a misspelling of "compatibility"
test-data/PassengerDataAll.csv:11:8: "Sandstrom" is a misspelling of "Sandstorm"
test-data/PassengerDataAll.csv:204:9: "Youseff" is a misspelling of "Yousef"
test-data/PassengerDataAll.csv:257:31: "Maybelle" is a misspelling of "Maybelline"
test-data/PassengerDataAll.csv:395:9: "Sandstrom" is a misspelling of "Sandstorm"
test-data/PassengerDataAllWithHeader.csv:12:8: "Sandstrom" is a misspelling of "Sandstorm"
test-data/PassengerDataAllWithHeader.csv:205:9: "Youseff" is a misspelling of "Yousef"
test-data/PassengerDataAllWithHeader.csv:258:31: "Maybelle" is a misspelling of "Maybelline"
test-data/PassengerDataAllWithHeader.csv:396:9: "Sandstrom" is a misspelling of "Sandstorm"
testkit/build/resources/main/cities.txt:63:0: "Capitola" is a misspelling of "Capital"
testkit/build/resources/main/lastnames.txt:4480:0: "VILLEGAS" is a misspelling of "VILLAGES"
testkit/src/main/resources/cities.txt:63:0: "Capitola" is a misspelling of "Capital"
testkit/src/main/resources/lastnames.txt:4480:0: "VILLEGAS" is a misspelling of "VILLAGES"
testkit/src/main/scala/com/salesforce/op/testkit/RandomStream.scala:259:17: "minimium" is a misspelling of "minimum"

after

$ misspell .
core/src/test/scala/com/salesforce/op/stages/impl/feature/TextTokenizerTest.scala:114:19: "comision" is a misspelling of "commission"
core/src/test/scala/com/salesforce/op/stages/impl/feature/TextTokenizerTest.scala:116:18: "clas" is a misspelling of "class"
helloworld/src/main/resources/TitanicDataset/TitanicPassengersTrainData.csv:11:8: "Sandstrom" is a misspelling of "Sandstorm"
helloworld/src/main/resources/TitanicDataset/TitanicPassengersTrainData.csv:204:9: "Youseff" is a misspelling of "Yousef"
helloworld/src/main/resources/TitanicDataset/TitanicPassengersTrainData.csv:257:31: "Maybelle" is a misspelling of "Maybelline"
helloworld/src/main/resources/TitanicDataset/TitanicPassengersTrainData.csv:395:9: "Sandstrom" is a misspelling of "Sandstorm"
test-data/PassengerDataAll.csv:11:8: "Sandstrom" is a misspelling of "Sandstorm"
test-data/PassengerDataAll.csv:204:9: "Youseff" is a misspelling of "Yousef"
test-data/PassengerDataAll.csv:257:31: "Maybelle" is a misspelling of "Maybelline"
test-data/PassengerDataAll.csv:395:9: "Sandstrom" is a misspelling of "Sandstorm"
test-data/PassengerDataAllWithHeader.csv:12:8: "Sandstrom" is a misspelling of "Sandstorm"
test-data/PassengerDataAllWithHeader.csv:205:9: "Youseff" is a misspelling of "Yousef"
test-data/PassengerDataAllWithHeader.csv:258:31: "Maybelle" is a misspelling of "Maybelline"
test-data/PassengerDataAllWithHeader.csv:396:9: "Sandstrom" is a misspelling of "Sandstorm"
testkit/build/resources/main/cities.txt:63:0: "Capitola" is a misspelling of "Capital"
testkit/build/resources/main/lastnames.txt:4480:0: "VILLEGAS" is a misspelling of "VILLAGES"
testkit/src/main/resources/cities.txt:63:0: "Capitola" is a misspelling of "Capital"
testkit/src/main/resources/lastnames.txt:4480:0: "VILLEGAS" is a misspelling of "VILLAGES"

Describe alternatives you've considered
None.

Additional context
None.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @seratch to sign the Salesforce.com Contributor License Agreement.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #66 into master will increase coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   85.31%   85.79%   +0.48%     
==========================================
  Files         298      298              
  Lines        9004     9760     +756     
  Branches      299      535     +236     
==========================================
+ Hits         7682     8374     +692     
- Misses       1322     1386      +64
Impacted Files Coverage Δ
...ssification/OpMultilayerPerceptronClassifier.scala 63.63% <ø> (ø) ⬆️
...n/scala/com/salesforce/op/dsl/RichMapFeature.scala 84.21% <ø> (ø) ⬆️
...com/salesforce/op/evaluators/OpEvaluatorBase.scala 96.87% <ø> (ø) ⬆️
...e/op/stages/impl/feature/SmartTextVectorizer.scala 97.4% <ø> (ø) ⬆️
...p/stages/impl/feature/SmartTextMapVectorizer.scala 100% <ø> (ø) ⬆️
...tages/impl/preparators/SanityCheckerMetadata.scala 92.2% <ø> (ø) ⬆️
.../apache/spark/ml/SparkMLSharedParamConstants.scala 0% <ø> (ø) ⬆️
...scala/com/salesforce/op/testkit/RandomStream.scala 100% <ø> (+100%) ⬆️
.../main/scala/com/salesforce/op/stages/package.scala 33.33% <ø> (ø) ⬆️
...m/salesforce/op/utils/spark/OpVectorMetadata.scala 82.6% <ø> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e68ad...7a0a2ce. Read the comment docs.

@tovbinm tovbinm merged commit 091d398 into salesforce:master Aug 17, 2018
@seratch
Copy link
Contributor Author

seratch commented Aug 17, 2018

@tovbinm Thank you for very quickly merging this!

@tovbinm
Copy link
Collaborator

tovbinm commented Aug 17, 2018

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants