Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp remove codecov and circleci config #558

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Conversation

winterslu
Copy link
Contributor

Related issues
Codecov Remediation (internal ticket: W-9559189)

Describe the proposed solution
Removing codecov due to security breach

Describe alternatives you've considered
Looking for code coverage replacement to codecov, alternatives will also need to be reviewed by CSIRT

Copy link
Contributor

@nicodv nicodv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winterslu
Copy link
Contributor Author

@nicodv @crupley do you guys know if CircleCI config need to update? I dont have permission to view. Also granting me permission helps me experiment alternatives

@crupley
Copy link
Contributor

crupley commented Jul 22, 2021

Could you also remove from Travis build config?

https://github.com/salesforce/TransmogrifAI/blob/master/.travis.yml#L15-L16

@nicodv
Copy link
Contributor

nicodv commented Jul 22, 2021

Please remove README badge for Codecov too, @winterslu

@tovbinm
Copy link
Collaborator

tovbinm commented Jul 22, 2021

Oh, was there another breach?

@winterslu
Copy link
Contributor Author

@tovbinm do you know why Travis is not triggered build? Is it caused by Travis config change?

@crupley
Copy link
Contributor

crupley commented Jul 23, 2021

@tovbinm no new breach, but because of the previous breach, Security team has mandated that we can no longer use codecov.

@tovbinm
Copy link
Collaborator

tovbinm commented Jul 23, 2021

@winterslu TravisCI has the following error:
Screen Shot 2021-07-23 at 10 49 44 AM

@tovbinm
Copy link
Collaborator

tovbinm commented Jul 23, 2021

Please contact the Salesforce account administrator for TravisCI and bump up the plan.

@winterslu winterslu merged commit 8d2a9da into master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants