Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null Imputation for DateUnitCircleVectorizer #555

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Null Imputation for DateUnitCircleVectorizer #555

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
810edcc
Changing Name
mweilsalesforce Jun 3, 2021
533e281
Adding default radians for null
mweilsalesforce Jun 3, 2021
660c269
radians instead of randians
mweilsalesforce Jun 3, 2021
49425a8
Changing transformer test
mweilsalesforce Jun 7, 2021
0cab7fb
Merge branch 'master' into mw/DateImputation
tovbinm Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
radians instead of randians
  • Loading branch information
@mweilsalesforce
mweilsalesforce committed Jun 3, 2021
commit 660c2694f9edcd09d30891dd902de04ba37c869a
4 changes: 2 additions & 2 deletions core/src/main/scala/com/salesforce/op/stages/impl/feature/DateToUnitCircleTransformer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ class DateToUnitCircleTransformer[T <: Date]
) with DateToUnitCircleParams {

override def transformFn: Seq[T] => OPVector = timestamp => {
val randians = timestamp.flatMap(ts => DateToUnitCircle.convertToRadians(ts.v, getTimePeriod)).toArray
Vectors.dense(randians).toOPVector
val radians = timestamp.flatMap(ts => DateToUnitCircle.convertToRadians(ts.v, getTimePeriod)).toArray
Vectors.dense(radians).toOPVector
}

override def onGetMetadata(): Unit = {
Expand Down