Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cr/fixed codecov ver #552

Merged
merged 5 commits into from
Apr 22, 2021
Merged

Cr/fixed codecov ver #552

merged 5 commits into from
Apr 22, 2021

Conversation

crupley
Copy link
Contributor

@crupley crupley commented Apr 22, 2021

Related issues
Refer to issue(s) addressed in this pull request from Issues page.

As the result of the recent CodeCov security breach, it would be preferred to use a fixed version rather than automatically upgrade to another potentially insecure version.

Describe the proposed solution
A clear and concise description of what the changes are.

Add the CodeCov script to repo and execute the static version.

This is the advised solution from CodeCov in response to my email request:

We are working on a new version that will compile into binaries. For now you can vendor the bash script into your repo and execute it there. That way it will not change until/unless you update it.
Ticket: https://codecov.freshdesk.com/helpdesk/tickets/4907

The script added here was obtained from curl -s https://codecov.io/bash on 4/22/21

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context about the changes here.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #552 (8b19420) into master (44a5dce) will decrease coverage by 9.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   86.79%   77.02%   -9.78%     
==========================================
  Files         347      347              
  Lines       12026    12026              
  Branches      403      403              
==========================================
- Hits        10438     9263    -1175     
- Misses       1588     2763    +1175     
Impacted Files Coverage Δ
.../main/scala/com/salesforce/op/FeatureHistory.scala 0.00% <0.00%> (-100.00%) ⬇️
...in/scala/com/salesforce/op/utils/table/Table.scala 0.00% <0.00%> (-100.00%) ⬇️
...ala/com/salesforce/op/readers/CSVAutoReaders.scala 0.00% <0.00%> (-100.00%) ⬇️
...salesforce/op/utils/json/EnumEntrySerializer.scala 0.00% <0.00%> (-100.00%) ⬇️
...sforce/op/aggregators/CustomMonoidAggregator.scala 0.00% <0.00%> (-100.00%) ⬇️
...sforce/op/stages/base/binary/BinaryEstimator.scala 0.00% <0.00%> (-100.00%) ⬇️
.../op/stages/impl/feature/TextMapNullEstimator.scala 0.00% <0.00%> (-100.00%) ⬇️
...orce/op/stages/base/ternary/TernaryEstimator.scala 0.00% <0.00%> (-100.00%) ⬇️
...stages/impl/feature/TimePeriodMapTransformer.scala 0.00% <0.00%> (-100.00%) ⬇️
...sql/execution/datasources/csv/CSVSchemaUtils.scala 0.00% <0.00%> (-100.00%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a5dce...8b19420. Read the comment docs.

Copy link
Contributor

@nicodv nicodv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crupley crupley merged commit 90a0f29 into master Apr 22, 2021
@crupley crupley deleted the cr/fixedCodecovVer branch April 22, 2021 17:55
@tovbinm
Copy link
Collaborator

tovbinm commented Apr 22, 2021

@crupley is this the official bash script? It's worth mentioning in the ticket where the script is coming from.

@crupley
Copy link
Contributor Author

crupley commented Apr 22, 2021

@crupley is this the official bash script? It's worth mentioning in the ticket where the script is coming from.

@tovbinm Yes, this is the same script that was being used previously. I've updated the PR description to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants