Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Hadoop config from Spark session #542

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Conversation

nicodv
Copy link
Contributor

@nicodv nicodv commented Feb 18, 2021

Related issues
N/A

Describe the proposed solution
We were getting a fresh Hadoop configuration, instead of getting it from the SparkSession. Hence, it will miss out on any configurations that were set.

Describe alternatives you've considered
N/A

Additional context
N/A

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nicodv nicodv merged commit 975eb2f into master Feb 18, 2021
@nicodv nicodv deleted the ndv/modelwriter-hadoopconf branch February 18, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants