@W-8295960@ avoid repeated codec factory initialization #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovbinm
reviewed
Oct 30, 2020
| @@ -268,6 +268,8 @@ private object WorkflowFileReader { | |||
| val rawModel = "rawModel" | |||
| val zipModel = "Model.zip" | |||
| def modelStagingDir: String = s"modelStagingDir/model-${System.currentTimeMillis}" | |||
| val confWithDefaultCodec = new Configuration(false) | |||
| val codecFactory = new CompressionCodecFactory(confWithDefaultCodec) | |||
There was a problem hiding this comment.
Is it reusable? Is this thread-safe?
There was a problem hiding this comment.
I think it is.
The codec factory maps are fully populated after the constructor and val is final.
Each usage of the WorkflowReader singleton in a different thread necessarily is synchronized with the classloader static class initialization.
So there is proper JMM happens-before order between the consistent codec factory and the future getCodec lookups.
leahmcguire
approved these changes
Oct 30, 2020
gerashegalov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#527
Describe the proposed solution
move out as an object field with only default codecs (Gzip and deflate)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the changes here.