Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved some multilabel stages to public repo. These stages convert the indexed probabilities predicted to named classes with probabilities. #509

Merged
merged 5 commits into from
Sep 4, 2020

Conversation

leahmcguire
Copy link
Collaborator

Related issues
Fixed metadata comparison and added error message about stage that failed when mleap serialization does not work.

Describe the proposed solution
A clear and concise description of what the changes are.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context about the changes here.

Copy link
Collaborator

@TuanNguyen27 TuanNguyen27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #509 into master will increase coverage by 56.24%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #509       +/-   ##
===========================================
+ Coverage   22.15%   78.40%   +56.24%     
===========================================
  Files         346      347        +1     
  Lines       11848    11859       +11     
  Branches      612      606        -6     
===========================================
+ Hits         2625     9298     +6673     
+ Misses       9223     2561     -6662     
Impacted Files Coverage Δ
...orce/op/stages/impl/feature/MultiLabelJoiner.scala 40.00% <40.00%> (ø)
...ala/com/salesforce/op/stages/SparkStageParam.scala 54.38% <100.00%> (+0.81%) ⬆️
...a/com/salesforce/op/test/OpPipelineStageSpec.scala 97.95% <100.00%> (+97.95%) ⬆️
...ala/com/salesforce/op/features/types/package.scala 55.47% <0.00%> (+0.68%) ⬆️
.../stages/impl/feature/OpIndexToStringNoFilter.scala 6.25% <0.00%> (+6.25%) ⬆️
...la/com/salesforce/op/features/FeatureBuilder.scala 33.79% <0.00%> (+6.89%) ⬆️
...orce/op/aggregators/MonoidAggregatorDefaults.scala 92.85% <0.00%> (+7.14%) ⬆️
...ain/scala/com/salesforce/op/features/Feature.scala 33.33% <0.00%> (+8.33%) ⬆️
...scala/com/salesforce/op/features/types/Lists.scala 75.00% <0.00%> (+8.33%) ⬆️
... and 198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b41236...4df9b5a. Read the comment docs.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add license header in all the files

@leahmcguire leahmcguire merged commit 31baee7 into master Sep 4, 2020
@leahmcguire leahmcguire deleted the lm/multiLabel branch September 4, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants