Incorporate name detection into SmartTextVectorizer #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onoids instead of custom accumulators
… Still need to fix HLL serialization in Spark issue
…ix printing bug for NameDetectStats
…stead of moments of text length; Still need to fix no moments higher than the 1st being calculated
…Cleaned up test code
Jauntbox
requested review from
gerashegalov,
leahmcguire,
tovbinm and
wsuchy
as code owners
|
Right now, this is just compiling and passing tests so far. I still have to give it a pass to clean things up before it's ready for a real review |
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 79.15% 86.73% +7.57%
==========================================
Files 347 347
Lines 11851 11897 +46
Branches 384 602 +218
==========================================
+ Hits 9381 10319 +938
+ Misses 2470 1578 -892
Continue to review full report at Codecov.
|
leahmcguire
reviewed
Sep 11, 2020
| // val valueStats: Dataset[Array[TextStats]] = dataset.map( | ||
| // _.map(TextStats.computeTextStats(_, shouldCleanText, shouldTokenizeForLengths, maxCard)).toArray | ||
| // ) | ||
| // val aggregatedStats: Array[TextStats] = valueStats.reduce(_ + _) |
There was a problem hiding this comment.
remove commented lines
leahmcguire
reviewed
Sep 11, 2020
| import com.salesforce.op.utils.spark.{OpVectorColumnMetadata, OpVectorMetadata} | ||
| >>>>>>> 4d461814d1791ef7e6dd14b262cf6a8a303ffcde |
There was a problem hiding this comment.
please fix merge conflict
leahmcguire
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Re-opening of #456 on branch directly on TransmogrifAI, please see that PR for historical discussion (I'll close once this one gets merged in).
Describe the proposed solution
Adds parameters for ignoring fields identified as personal names to SmartTextVectorizer
Describe alternatives you've considered
N/A
Additional context
N/A