put feature feature corr behind flag #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahmcguire
requested review from
gerashegalov,
Jauntbox,
tovbinm and
wsuchy
as code owners
tovbinm
approved these changes
May 29, 2020
| @@ -555,6 +555,8 @@ class SanityCheckerTest extends OpEstimatorSpec[OPVector, BinaryModel[RealNN, OP | |||
|
|
|||
| val transformed = new OpWorkflow().setResultFeatures(smartMapVectorized, checkedFeatures).transform(textData) | |||
|
|
|||
| transformed | |||
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
+ Coverage 81.41% 87.02% +5.60%
==========================================
Files 345 345
Lines 11667 11673 +6
Branches 384 388 +4
==========================================
+ Hits 9499 10158 +659
+ Misses 2168 1515 -653
Continue to review full report at Codecov.
|
nicodv
approved these changes
May 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Feature feature correlations in sanity metadata can make the model too large to load
Describe the proposed solution
A clear and concise description of what the changes are.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the changes here.