Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift upperBound on # of hash features #477

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

TuanNguyen27
Copy link
Collaborator

Related issues
Some use cases require a much larger hash space when hashing text features. We are relaxing this limit in HashingVectorizerParams and TextMapHashingVectorizer

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #477 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   87.01%   87.01%   -0.01%     
==========================================
  Files         345      345              
  Lines       11671    11667       -4     
  Branches      379      384       +5     
==========================================
- Hits        10156    10152       -4     
  Misses       1515     1515              
Impacted Files Coverage Δ
...s/impl/feature/OPCollectionHashingVectorizer.scala 96.50% <ø> (-0.05%) ⬇️
...force/op/stages/impl/feature/OPMapVectorizer.scala 97.77% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d222438...f8d7ae8. Read the comment docs.

@TuanNguyen27 TuanNguyen27 merged commit 93e1fde into master May 21, 2020
@nicodv nicodv mentioned this pull request Jun 11, 2020
@tovbinm tovbinm deleted the new_upperBound branch June 12, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants