Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow result features to be removed by raw feature filter #458

Merged
merged 3 commits into from
Jan 24, 2020

Conversation

leahmcguire
Copy link
Collaborator

Related issues
Result features removed by raw feature filter throw an error, but sometimes we wish to allow them to be removed.

Describe the proposed solution
Created a flag that allows removal of result features by raw feature filter

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context about the changes here.

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@df160d5). Click here to learn what that means.
The diff coverage is 98.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #458   +/-   ##
=========================================
  Coverage          ?   86.95%           
=========================================
  Files             ?      340           
  Lines             ?    11428           
  Branches          ?      363           
=========================================
  Hits              ?     9937           
  Misses            ?     1491           
  Partials          ?        0
Impacted Files Coverage Δ
...e/op/stages/impl/feature/SmartTextVectorizer.scala 95.61% <ø> (ø)
...s/impl/feature/OPCollectionHashingVectorizer.scala 96.55% <100%> (ø)
.../src/main/scala/com/salesforce/op/OpWorkflow.scala 88.96% <100%> (ø)
...p/stages/impl/feature/SmartTextMapVectorizer.scala 100% <100%> (ø)
...scala/com/salesforce/op/features/types/Lists.scala 75% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df160d5...fe20792. Read the comment docs.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@@ -534,8 +549,10 @@ class OpWorkflow(val uid: String = UID[OpWorkflow]) extends OpWorkflowCore {
protectedJSFeatures: Array[OPFeature] = Array.empty,
textBinsFormula: (Summary, Int) => Int = RawFeatureFilter.textBinsFormula,
timePeriod: Option[TimePeriod] = None,
minScoringRows: Int = RawFeatureFilter.minScoringRowsDefault
minScoringRows: Int = RawFeatureFilter.minScoringRowsDefault,
finalFeatureRetentionPolicy: ResultFeatureRetention = ResultFeatureRetention.Strict
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename finalFeatureRetentionPolicy to resultFeatureRetentionPolicy

@leahmcguire leahmcguire merged commit a51212a into master Jan 24, 2020
@leahmcguire leahmcguire deleted the lm/allowResultsRemove branch January 24, 2020 17:06
@nicodv nicodv mentioned this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants