Metadata changes for sensitive feature information #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he to/fromMetadata tests
MWYang
requested review from
gerashegalov,
Jauntbox,
leahmcguire,
tovbinm and
wsuchy
as code owners
…and SmartTextMapVectorizer the same as previous behavior - don't ignore any features
Jauntbox
reviewed
Jan 22, 2020
utils/src/main/scala/com/salesforce/op/SensitiveFeatureInformation.scala
Outdated
Show resolved
Hide resolved
Jauntbox
reviewed
Jan 23, 2020
Jauntbox
reviewed
Jan 23, 2020
features/src/test/scala/com/salesforce/op/utils/spark/OPVectorMetadataTest.scala
Outdated
Show resolved
Hide resolved
Jauntbox
reviewed
Jan 23, 2020
utils/src/test/scala/com/salesforce/op/SensitiveFeatureInformationTest.scala
Outdated
Show resolved
Hide resolved
Jauntbox
reviewed
Jan 23, 2020
utils/src/test/scala/com/salesforce/op/SensitiveFeatureInformationTest.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 86.99% 86.99%
=======================================
Files 341 341
Lines 11475 11475
Branches 397 397
=======================================
Hits 9983 9983
Misses 1492 1492Continue to review full report at Codecov.
|
Jauntbox
reviewed
Jan 27, 2020
Merged
|
Thanks for the contribution! It looks like @MWYang is an internal user so signing the CLA is not required. However, we need to confirm this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the proposed solution
Adds a place in
FeatureInsightsto track information about sensitive feature information (detected by something like #456).OpVectorMetadatanow has a constructor argument for a map from feature names to a new class,SensitiveFeatureInformation, which will then be read out correctly intoFeatureInsights.Additional context
Merge this PR before merging #456.