Added Chinese and Korean examples to TextTokenizerTest #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jauntbox
requested review from
gerashegalov,
leahmcguire,
tovbinm and
wsuchy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 337 337
Lines 11096 11096
Branches 362 362
=======================================
Hits 9646 9646
Misses 1450 1450Continue to review full report at Codecov.
|
|
@tovbinm The LOCO test - |
|
It’s a flaky one. See previous runs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
n/a
Describe the proposed solution
n/a
Describe alternatives you've considered
n/a
Additional context
This is a small change to better allow testing of alternatives to the CJK tokenizer (that we've already replaced for Japanese). The CJK tokenizer uses bigrams for its tokenization, rather than trying to extract words, so most of the tokens from a text sample will have length 2 (not all, since other languages can be mixed in). Some of the simpler ID detection calculations will look at the distributions of token lengths, so they may incorrectly think that text from languages using the CJK tokenizer is IDs.