Property-based GLM test #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelweilsalesforce
requested review from
gerashegalov,
Jauntbox,
leahmcguire,
tovbinm and
wsuchy
as code owners
|
@michaelweilsalesforce please update PR description. also, is it ready for review? |
tovbinm
reviewed
Oct 19, 2019
| @@ -262,6 +261,7 @@ private[op] case object FitStagesUtil { | |||
| val stages = stagesLayer.map(_._1) | |||
| val (estimators, noFit) = stages.partition(_.isInstanceOf[Estimator[_]]) | |||
| val fitEstimators = estimators.map { case e: Estimator[_] => | |||
| println(e.getInputFeatures().toSeq) | |||
|
@Jauntbox These tests are actually painful for our runtime (~15-20 mins/ unit test) |
|
Builds will be killed if not output is produced for 10 minutes, so we can’t have an individual test take longer than that. |
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
+ Coverage 86.94% 86.96% +0.01%
==========================================
Files 337 337
Lines 11082 11083 +1
Branches 355 356 +1
==========================================
+ Hits 9635 9638 +3
+ Misses 1447 1445 -2
Continue to review full report at Codecov.
|
leahmcguire
approved these changes
Oct 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Adding more Tests for our ML capabilities (TDD)
Describe the proposed solution
Property based tests to check each of our the Regression Models (Linear Regression, Random Forest, GLM) will be picked based on the nature of the data (and response) generated
Describe alternatives you've considered
Doing the same tests on one single dataset instead