Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added call of validation prepare before model selection when no dag i… #424

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

leahmcguire
Copy link
Collaborator

…s passed

Related issues
Refer to issue(s) addressed in this pull request from Issues page.

Describe the proposed solution
A clear and concise description of what the changes are.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context about the changes here.

@tovbinm
Copy link
Collaborator

tovbinm commented Oct 16, 2019

Is there a way to test it? Should a user be able to disable it if needed?

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #424 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   86.99%   86.95%   -0.04%     
==========================================
  Files         337      337              
  Lines       11078    11078              
  Branches      369      597     +228     
==========================================
- Hits         9637     9633       -4     
- Misses       1441     1445       +4
Impacted Files Coverage Δ
...op/stages/impl/tuning/OpTrainValidationSplit.scala 100% <ø> (ø) ⬆️
...orce/op/stages/impl/tuning/OpCrossValidation.scala 97.95% <ø> (ø) ⬆️
...cala/com/salesforce/op/cli/gen/ProblemSchema.scala 91.37% <0%> (-5.18%) ⬇️
...in/scala/com/salesforce/op/cli/gen/AvroField.scala 74.35% <0%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d38090...eeb0e1e. Read the comment docs.

@leahmcguire
Copy link
Collaborator Author

You disable by not having a splitter. And it is not really testable in our current config since it was a bug in the internals of the validation model selection which may or may not effect which model wins but would not effect the final trained model since the selected model did have this stage applied correctly

@gerashegalov
Copy link
Contributor

Oh this is what I was looking in #246 but then it turned out a non-issue in my investigation. We need indeed this covered by tests (re @tovbinm) given the splitter lifecycle issues we have faced.

@leahmcguire leahmcguire merged commit 0c57d96 into master Oct 17, 2019
@leahmcguire leahmcguire deleted the lm/validPrep branch October 17, 2019 20:02
@nicodv nicodv mentioned this pull request Jun 11, 2020
@salesforce-cla
Copy link

salesforce-cla bot commented Nov 5, 2020

Thanks for the contribution! It looks like @leahmcguire is an internal user so signing the CLA is not required. However, we need to confirm this.

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): leahmcguire <l***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants