Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more loss types for OpLinearRegression #421

Merged
merged 5 commits into from
Oct 19, 2019
Merged

Enable more loss types for OpLinearRegression #421

merged 5 commits into from
Oct 19, 2019

Conversation

TuanNguyen27
Copy link
Collaborator

Since Spark 2.3.0, Huber loss is supported for SparkML's linear regression, which will be more robust against outliers.

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #421 into master will increase coverage by 4.87%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   82.09%   86.96%   +4.87%     
==========================================
  Files         337      337              
  Lines       11078    11082       +4     
  Branches      597      588       -9     
==========================================
+ Hits         9094     9637     +543     
+ Misses       1984     1445     -539
Impacted Files Coverage Δ
...op/stages/impl/regression/OpLinearRegression.scala 76.92% <50%> (-4.9%) ⬇️
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️
...sforce/op/stages/impl/feature/Transmogrifier.scala 98.02% <0%> (+1.12%) ⬆️
...com/salesforce/op/utils/stages/FitStagesUtil.scala 94.73% <0%> (+1.31%) ⬆️
...ala/com/salesforce/op/features/types/package.scala 57.93% <0%> (+1.37%) ⬆️
.../scala/com/salesforce/op/dsl/RichTextFeature.scala 83.09% <0%> (+1.4%) ⬆️
.../main/scala/com/salesforce/op/OpWorkflowCore.scala 95.45% <0%> (+1.51%) ⬆️
...n/scala/com/salesforce/op/readers/DataReader.scala 95.23% <0%> (+1.58%) ⬆️
...orce/op/stages/impl/tuning/OpCrossValidation.scala 97.95% <0%> (+2.04%) ⬆️
...a/com/salesforce/op/filters/RawFeatureFilter.scala 92.97% <0%> (+2.16%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67626f...72960e8. Read the comment docs.

@tovbinm tovbinm merged commit 9b41f02 into master Oct 19, 2019
@tovbinm tovbinm deleted the lrLoss branch October 19, 2019 17:18
@nicodv nicodv mentioned this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants