Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Turn off logging for cardEstimate & track token length instead of token value" #419

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

leahmcguire
Copy link
Collaborator

Reverts #416

This change is bad. The information here is needed to differentiate text and categoricals and the counts is redundant with the moments calculation.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #419 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   86.97%   86.97%   -0.01%     
==========================================
  Files         337      337              
  Lines       11079    11078       -1     
  Branches      376      597     +221     
==========================================
- Hits         9636     9635       -1     
  Misses       1443     1443
Impacted Files Coverage Δ
...om/salesforce/op/filters/FeatureDistribution.scala 98.63% <ø> (-0.02%) ⬇️
...in/scala/com/salesforce/op/cli/gen/AvroField.scala 71.79% <0%> (-5.13%) ⬇️
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ea2ed...312da40. Read the comment docs.

@tovbinm tovbinm merged commit 6589656 into master Oct 11, 2019
@tovbinm tovbinm deleted the revert-416-cardOff branch October 11, 2019 15:24
gerashegalov added a commit that referenced this pull request Oct 11, 2019
…h instead of token value (#416)" (#419)"

This reverts commit 6589656.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants