Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mq/model selector uid bug #40

Merged
merged 4 commits into from
Aug 8, 2018
Merged

Mq/model selector uid bug #40

merged 4 commits into from
Aug 8, 2018

Conversation

minhanquinn
Copy link
Contributor

multiClassificationModelSelector stage 1 uid is "Stage1BinaryClassificationModelSelector" - fixed so that it is correctly labeled as "Stage1MultiClassificationModelSelector"

@salesforce-cla
Copy link

salesforce-cla bot commented Aug 8, 2018

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Minh-An Quinn <m***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #40 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #40      +/-   ##
=========================================
+ Coverage   83.88%   83.9%   +0.02%     
=========================================
  Files         296     296              
  Lines        9679    9679              
  Branches      349     544     +195     
=========================================
+ Hits         8119    8121       +2     
+ Misses       1560    1558       -2
Impacted Files Coverage Δ
...ssification/MultiClassificationModelSelector.scala 100% <100%> (ø) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.58% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa352a8...10cbf56. Read the comment docs.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Please update your email for CLA

@tovbinm tovbinm merged commit f896fe7 into master Aug 8, 2018
@tovbinm tovbinm deleted the mq/modelSelector_uid_bug branch August 8, 2018 16:04
@salesforce-cla
Copy link

salesforce-cla bot commented Aug 8, 2018

Thanks for the contribution! It looks like @minhanquinn is an internal user so signing the CLA is not required. However, we need to confirm this.

@jamesward
Copy link
Contributor

@minhanquinn I've invited you to this org: https://github.com/salesforce

Once you accept, refresh the status of the CLA bot: https://cla.salesforce.com/status/salesforce/TransmogrifAI/pull/40

ericwayman pushed a commit that referenced this pull request Feb 8, 2019
multiClassificationModelSelector stage 1 uid is "Stage1BinaryClassificationModelSelector" - fixed so that it is correctly labeled as "Stage1MultiClassificationModelSelector"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants