Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata to OpStandardScaler to allow for descaling #378

Merged
merged 11 commits into from
Aug 5, 2019
Merged

Add metadata to OpStandardScaler to allow for descaling #378

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e5eb137
Add metadata to OpScalarStandardScaler
Aug 1, 2019
804a7e7
Add test for descaling to OpScalarStandardScaler tests
Aug 1, 2019
7459f31
Fix scalastyle
Aug 1, 2019
007467e
Merge branch 'master' into ec/standardMetadata
Aug 1, 2019
8c22ace
Merge branch 'master' into ec/standardMetadata
Aug 1, 2019
c6deab5
Improve tests
Aug 2, 2019
560e9c1
Merge branch 'ec/standardMetadata' of https://github.com/salesforce/T…
Aug 2, 2019
2b02ec8
Merge branch 'master' into ec/standardMetadata
Aug 2, 2019
36edde1
Add explanation to selection of std and mean
Aug 5, 2019
f1a184e
Merge branch 'ec/standardMetadata' of https://github.com/salesforce/T…
Aug 5, 2019
4674762
Add clarification
Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions core/src/main/scala/com/salesforce/op/stages/impl/feature/OpScalarStandardScaler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,13 @@ class OpScalarStandardScaler

val std = scalerModel.std.toArray
erica-chiu marked this conversation as resolved.
Show resolved Hide resolved
val mean = scalerModel.mean.toArray
if (std.length == 1) {
val stdMean = std.head
val meanMean = mean.head
val scalingArgs = LinearScalerArgs(1 / stdMean, - meanMean / stdMean)
val meta = ScalerMetadata(ScalingType.Linear, scalingArgs).toMetadata()
setMetadata(meta)
}

// Since is a UnaryEstimator, exactly one value will be in std and mean
erica-chiu marked this conversation as resolved.
Show resolved Hide resolved
val stdVal = std.head
val meanVal = mean.head
val scalingArgs = LinearScalerArgs(1 / stdVal, - meanVal / stdVal)
val meta = ScalerMetadata(ScalingType.Linear, scalingArgs).toMetadata()
setMetadata(meta)

new OpScalarStandardScalerModel(
std = std,
Expand Down