-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forecast Evaluator - fixes SMAPE, adds MASE and Seasonal Error metrics #342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 86.65% 78.82% -7.84%
==========================================
Files 335 335
Lines 10763 10781 +18
Branches 344 335 -9
==========================================
- Hits 9327 8498 -829
- Misses 1436 2283 +847
Continue to review full report at Codecov.
|
core/src/main/scala/com/salesforce/op/evaluators/EvaluationMetrics.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/salesforce/op/evaluators/OpForecastEvaluator.scala
Show resolved
Hide resolved
core/src/main/scala/com/salesforce/op/evaluators/OpForecastEvaluator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/salesforce/op/evaluators/OpForecastEvaluator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/salesforce/op/evaluators/OpForecastEvaluator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/salesforce/op/evaluators/OpForecastEvaluator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/salesforce/op/evaluators/OpForecastEvaluator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/salesforce/op/evaluators/OpForecastEvaluator.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/salesforce/op/evaluators/OpForecastEvaluatorTest.scala
Outdated
Show resolved
Hide resolved
if |
@tovbinm Therefore I am using |
var smapeSum = 0.0 | ||
|
||
while (i < cnt) { | ||
val r = rows(i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val (y, yHat) = rows(i)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…rifAI into ks/forecastEvaluator
Thanks for the contribution! Before we can merge this, we need @wsuchy to sign the Salesforce.com Contributor License Agreement. |
Fixed
SMAPE
and addedseasonal error
andMASE
.Computation is done locally due to the way the seasonal error is being calculated.