Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local scoring for model with features of all types #340

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Jun 22, 2019

Related issues
Local scoring needs more testing

Describe the proposed solution
Added a test that validates local scoring functionality of data with all feature types

Describe alternatives you've considered
N/A

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #340 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   86.61%   86.65%   +0.03%     
==========================================
  Files         334      334              
  Lines       10752    10752              
  Branches      354      565     +211     
==========================================
+ Hits         9313     9317       +4     
+ Misses       1439     1435       -4
Impacted Files Coverage Δ
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️
.../com/salesforce/op/local/MLeapModelConverter.scala 10.25% <0%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f55e7a...bb13cdd. Read the comment docs.

@tovbinm tovbinm merged commit 5b82f42 into master Jun 22, 2019
@tovbinm tovbinm deleted the tovbinm-patch-1 branch June 22, 2019 16:00
This was referenced Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant