Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated project name #33

Merged
merged 3 commits into from
Aug 8, 2018
Merged

updated project name #33

merged 3 commits into from
Aug 8, 2018

Conversation

ajayborra
Copy link
Contributor

  • Updated root project name in settings.gradle.
  • Updated docs string in *.scala, *.properties files.
  • Updated the jar naming scheme.
    Note:
    Expecting this PR to build & generate the new jars with transmogrifai- prefix and push to s3 bucket at s3:https://op-repo/releases/com/salesforce/op/, otherwise the helloworld/build.gradle will break since it would not find the new jars with the updated naming scheme.

@salesforce-cla
Copy link

salesforce-cla bot commented Aug 5, 2018

Thanks for the contribution! Before we can merge this, we need @ajayborra to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented Aug 5, 2018

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #33    +/-   ##
=======================================
  Coverage    83.9%   83.9%            
=======================================
  Files         296     296            
  Lines        9679    9679            
  Branches      349     544   +195     
=======================================
  Hits         8121    8121            
  Misses       1558    1558
Impacted Files Coverage Δ
.../src/main/scala/com/salesforce/op/OpWorkflow.scala 87.94% <ø> (ø) ⬆️
...m/salesforce/op/stages/OpPipelineStageParams.scala 90.9% <ø> (ø) ⬆️
...la/com/salesforce/op/stages/OpPipelineStages.scala 73% <ø> (ø) ⬆️
...ain/scala/com/salesforce/op/OpWorkflowRunner.scala 87.06% <ø> (ø) ⬆️
...m/salesforce/op/stages/OpPipelineStageWriter.scala 58.33% <ø> (ø) ⬆️
...ges/sparkwrappers/generic/SparkWrapperParams.scala 0% <0%> (ø) ⬆️
...in/scala/com/salesforce/op/cli/CommandParser.scala 98.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa352a8...32e8736. Read the comment docs.

@tovbinm
Copy link
Collaborator

tovbinm commented Aug 5, 2018

@ajayborra thank you for the change. we are still migrating some of our code from the internal repo. let's wait before it's done, then do the renames.

@ajayborra
Copy link
Contributor Author

thanks, @tovbinm Will check on this later.

@ajayborra
Copy link
Contributor Author

Please ignore the review request. Re-based the branch to the latest master to keep it up to date.
👍the new hooks for automatic triggers on reviewing workflows.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also try grep replace all the Octopus Prime occurrences (also lowercase optimus prime and octopus prime)

@@ -1 +1 @@
rootProject.name = 'octopus-prime-helloworld' /* << APP_NAME_LOWER */
rootProject.name = 'TransmogrifAI-helloworld' /* << APP_NAME_LOWER */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be lowercase

@ajayborra
Copy link
Contributor Author

Ran a case-insensitive grep for following strings/sub-strings optimus prime octopus prime octopus optimus prime. We got all cases covered for grep replace.

@tovbinm tovbinm merged commit 6009154 into salesforce:master Aug 8, 2018
@ajayborra ajayborra deleted the cleanup/update_project_name branch August 8, 2018 13:43
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants