Improved OpScalarStandardScalerTest #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
========================================
Coverage 86.51% 86.51%
========================================
Files 325 325
Lines 10581 10581
Branches 349 565 +216
========================================
Hits 9154 9154
Misses 1427 1427Continue to review full report at Codecov.
|
tovbinm
reviewed
May 13, 2019
|
|
||
| // create the feature to which the normalizer transformer will be applied | ||
| val someNumericFeature = FeatureBuilder.RealNN[StdScTestData].extract(_.someNumericFeature.toRealNN).asPredictor | ||
|
|
||
| lazy val testData: Dataset[StdScTestData] = DataStdScTest.input.toDS() | ||
|
|
||
| Spec[OpScalarStandardScaler] should |
There was a problem hiding this comment.
use it instead of Spec[OpScalarStandardScaler]
tovbinm
reviewed
May 13, 2019
|
|
||
| // create the feature to which the normalizer transformer will be applied | ||
| val someNumericFeature = FeatureBuilder.RealNN[StdScTestData].extract(_.someNumericFeature.toRealNN).asPredictor | ||
|
|
||
| lazy val testData: Dataset[StdScTestData] = DataStdScTest.input.toDS() |
There was a problem hiding this comment.
so why not replace with TestFeatureBuilder ?
tovbinm
approved these changes
May 13, 2019
….com:salesforce/TransmogrifAI into ks/improved-tests-OpScalarStandardScalerTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved OpScalarStandardScalerTest by extending OpEstimatorSpec