Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random test feature generator to generate datasets with features of *all* types #298

Merged
merged 8 commits into from
Apr 19, 2019

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Apr 19, 2019

Related issues
TestFeatureBuilder can only generate test features & dataframe for upto 5 features, but we have 51 different types total! We should be able to test all of them easily.

Describe the proposed solution

  1. Add random test feature generator - TestFeatureBuilder.random that allows generating all feature types
  2. Add test feature generator for arbitrary number of features
  3. I had to move some files around
  4. Removed some unused code

@tovbinm tovbinm requested a review from Jauntbox April 19, 2019 07:28
@tovbinm tovbinm changed the title Add random test feature generator - TestFeatureBuilder.random Add random test feature generator to generate features of *all* types Apr 19, 2019
@tovbinm tovbinm changed the title Add random test feature generator to generate features of *all* types Add random test feature generator to generate datasets with features of *all* types Apr 19, 2019
@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #298 into master will increase coverage by 0.06%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   86.35%   86.42%   +0.06%     
==========================================
  Files         321      322       +1     
  Lines       10539    10570      +31     
  Branches      354      572     +218     
==========================================
+ Hits         9101     9135      +34     
+ Misses       1438     1435       -3
Impacted Files Coverage Δ
...n/scala/com/salesforce/op/testkit/RandomData.scala 100% <ø> (ø) ⬆️
...scala/com/salesforce/op/test/FeatureTestBase.scala 0% <ø> (ø)
...n/scala/com/salesforce/op/testkit/RandomText.scala 100% <ø> (ø) ⬆️
...n/scala/com/salesforce/op/testkit/RandomReal.scala 90.47% <100%> (ø) ⬆️
...la/com/salesforce/op/test/TestFeatureBuilder.scala 100% <100%> (ø)
.../scala/com/salesforce/op/test/FeatureAsserts.scala 100% <100%> (ø)
...scala/com/salesforce/op/testkit/RandomVector.scala 90.47% <92.3%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213962e...831c31d. Read the comment docs.

@tovbinm tovbinm merged commit 3ac0a50 into master Apr 19, 2019
@tovbinm tovbinm deleted the mt/tfb-random branch April 19, 2019 21:45
@Jauntbox Jauntbox mentioned this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants