Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added base spec for testing Spark wrapping transformers #295

Merged
merged 4 commits into from
Apr 18, 2019

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Apr 18, 2019

Related issues
Spark wrapping transformers were missing a test spec

Describe the proposed solution

  1. Added SwTransformerSpec for testing Spark wrapping transformers
  2. Factored out some common functionality between OpTransformerSpec and SwTransformerSpec into private TransformerSpecCommon
  3. Updated OpIndexToStringTest to use it

@tovbinm tovbinm changed the title Added SwTransformerSpec Added base spec for testing Spark wrapping transformers Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #295 into master will decrease coverage by 0.17%.
The diff coverage is 51.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   86.41%   86.23%   -0.18%     
==========================================
  Files         319      320       +1     
  Lines       10452    10471      +19     
  Branches      346      562     +216     
==========================================
- Hits         9032     9030       -2     
- Misses       1420     1441      +21
Impacted Files Coverage Δ
...ala/com/salesforce/op/test/SwTransformerSpec.scala 0% <0%> (ø)
...ges/sparkwrappers/generic/SparkWrapperParams.scala 0% <0%> (ø) ⬆️
...ala/com/salesforce/op/test/OpTransformerSpec.scala 97.77% <100%> (ø) ⬆️
...cala/com/salesforce/op/cli/gen/ProblemSchema.scala 91.37% <0%> (-5.18%) ⬇️
...in/scala/com/salesforce/op/cli/gen/AvroField.scala 74.35% <0%> (-2.57%) ⬇️
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb9521...7517e6c. Read the comment docs.

Copy link
Contributor

@wsuchy wsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am just curious if checking the underlying type of the wrapper is really necessary.

Copy link
Contributor

@crupley crupley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one typo, LGTM

@tovbinm tovbinm merged commit 48bc18d into master Apr 18, 2019
@tovbinm tovbinm deleted the mt/sw-transformer-spec branch April 18, 2019 18:23
@tovbinm
Copy link
Collaborator Author

tovbinm commented Apr 18, 2019

LGTM, I am just curious if checking the underlying type of the wrapper is really necessary.

@wsuchy maybe not as it should be checked by compiler. But I dont think there is anything wrong to check in a test as well.

@Jauntbox Jauntbox mentioned this pull request May 2, 2019
@salesforce-cla
Copy link

Thanks for the contribution! It looks like @tovbinm is an internal user so signing the CLA is not required. However, we need to confirm this.

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Matthew Tovbin <m***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants