-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threshold metrics calculation fix when unseen labels are present #293
Merged
Merged
Changes from 1 commit
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
a0f5bc7
label metadata after data cut
gerashegalov 0a7d872
idempotent trim and special-case DataCutter
gerashegalov 8f900a1
ignore previous labels in metadata
gerashegalov 0b520ee
more logging
gerashegalov 0a775eb
num_vals instead of vals
gerashegalov 9da41b2
Revert "num_vals instead of vals"
gerashegalov 3e73aaa
fix metadata labels
gerashegalov bde7cf0
sync labels
gerashegalov c5d3272
add mkstring
gerashegalov 2ad6876
cleanup and fixes
gerashegalov e084d4e
WIP
gerashegalov 937dc17
Revert "cleanup and fixes"
gerashegalov a803644
rewwork labels dropped
gerashegalov ae1b58d
restore accidental revert
gerashegalov 4f7e2ef
re-add num_vals
gerashegalov 30f961d
WIP
gerashegalov 81f5ee9
WIP2
gerashegalov acff707
tests passing
gerashegalov aee7bbe
debug for leah
gerashegalov f140aa9
if inverted
gerashegalov 1b3bc27
LR repro'ed
gerashegalov 5074ff5
WIP
gerashegalov bcb93fd
test vectors
gerashegalov 8c6d685
test both indexed and non-idexed data with data cutter
gerashegalov f1bb79d
Leah's comments
gerashegalov da400d4
param for number dropped lables to log
gerashegalov 5a5b19d
WIP
gerashegalov 74e9dd1
WIP
gerashegalov 4a4171f
WIP
gerashegalov 2e467c1
WIP
gerashegalov 2d64f14
formatting
gerashegalov c43259d
Added metrics calculation to existing test to reproduce error seen in…
Jauntbox 5e99cb7
Fixed bug in threshold metrics when labels unseen at training time ar…
Jauntbox e89b647
Removed debug logging from test
Jauntbox cb17f96
Merge branch 'master' of github.com:salesforce/TransmogrifAI into km/…
Jauntbox 27ff0b9
label metadata after data cut
gerashegalov 453c1e1
idempotent trim and special-case DataCutter
gerashegalov 6b31bad
ignore previous labels in metadata
gerashegalov 2f0af21
more logging
gerashegalov 78acc4c
num_vals instead of vals
gerashegalov 3ee8149
Revert "num_vals instead of vals"
gerashegalov 4415245
fix metadata labels
gerashegalov 86e5425
sync labels
gerashegalov c3bda19
add mkstring
gerashegalov 6000be7
cleanup and fixes
gerashegalov 1fdbe3e
WIP
gerashegalov 4c5aa83
Revert "cleanup and fixes"
gerashegalov 896dcb0
rewwork labels dropped
gerashegalov 71d0b60
restore accidental revert
gerashegalov dd75509
re-add num_vals
gerashegalov 9af4edf
WIP
gerashegalov 62c489d
WIP2
gerashegalov e70a621
tests passing
gerashegalov af77fda
debug for leah
gerashegalov e545f8b
if inverted
gerashegalov 19c91be
LR repro'ed
gerashegalov 1948507
WIP
gerashegalov 0ee4ffb
test vectors
gerashegalov 9f592ac
test both indexed and non-idexed data with data cutter
gerashegalov 2841359
Leah's comments
gerashegalov cf55a49
param for number dropped lables to log
gerashegalov 5701b08
WIP
gerashegalov b9eb963
WIP
gerashegalov ae3e5c5
WIP
gerashegalov a44707b
WIP
gerashegalov 831e114
formatting
gerashegalov a1f37c3
Replace cacheValidatedDFForTesting with the extended DataCutter class…
gerashegalov b3db9c4
mt feedback WIP
gerashegalov dd16900
build failure fix
gerashegalov 0dd9fb6
whitespace
gerashegalov 37b2dce
column index constants
gerashegalov cc2d4f0
Param rename
gerashegalov e973f46
CodeFactor issue
gerashegalov 27992db
Merge branch 'master' into gera/factorlabeltrim
tovbinm 3029177
Merged with Gera's branch
Jauntbox 8197332
Fixed merge
Jauntbox 6bf7d72
Merge branch 'master' into km/label-trim-metrics
leahmcguire 0d8941b
Merge with master
Jauntbox a13cf54
Merge branch 'km/label-trim-metrics' of github.com:salesforce/Transmo…
Jauntbox 6970775
Put blank line back in
Jauntbox 9307140
Put blank line back in, but not with space
Jauntbox 69fad18
Address comment
Jauntbox 14b442d
Merge branch 'master' of github.com:salesforce/TransmogrifAI into km/…
Jauntbox 321bc7e
Merge branch 'master' of github.com:salesforce/TransmogrifAI into km/…
Jauntbox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "num_vals instead of vals"
This reverts commit d6d9ded
- Loading branch information
commit 9da41b226ede5279432074330cde892dd7f1e9bb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could keep those magic values as constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wsuchy This PR is very confusing because it's based and contains commits from an older version of #263. @Jauntbox's change is actually a small commit. @Jauntbox please open a PR stacked on mine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gerashegalov I don't know how to make this PR against your branch since it's from a branch on your fork. This should be up to date w/ your branch now. I was hoping we could merge your branch first and then this PR should reduce down to ~10 lines when I merge it with master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can fetch branches from other forks by
git remote add
other remotes first, branch off of it, and push to another remote, and and create a cross-fork PR. Here is a demo:https://github.com/tovbinm/TransmogrifAI/pull/1/files