Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TextTokenizerTest to use OpTransformerSpec #289

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Apr 17, 2019

Related issues
TextTokenizerTest does not use OpTransformerSpec

Describe the proposed solution
Update TextTokenizerTest to use OpTransformerSpec

Copy link
Contributor

@wsuchy wsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #289 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #289      +/-   ##
=========================================
- Coverage   86.42%   86.4%   -0.02%     
=========================================
  Files         319     319              
  Lines       10453   10453              
  Branches      351     561     +210     
=========================================
- Hits         9034    9032       -2     
- Misses       1419    1421       +2
Impacted Files Coverage Δ
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02fb32...26bc861. Read the comment docs.

@tovbinm tovbinm merged commit 1b3edfe into master Apr 17, 2019
@tovbinm tovbinm deleted the mt/text-tokenizer-test branch April 17, 2019 16:50
@Jauntbox Jauntbox mentioned this pull request May 2, 2019
@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Matthew <m***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants