Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved OPCollectionHashingVectorizerTest test #286

Merged
merged 4 commits into from
Apr 16, 2019
Merged

improved OPCollectionHashingVectorizerTest test #286

merged 4 commits into from
Apr 16, 2019

Conversation

wsuchy
Copy link
Contributor

@wsuchy wsuchy commented Apr 16, 2019

Improved OPCollectionHashingVectorizerTest by extending OpTransformerSpec

@wsuchy wsuchy requested a review from tovbinm April 16, 2019 17:25
@codecov
Copy link

codecov bot commented Apr 16, 2019 •
edited
Loading

Codecov Report

Merging #286 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage    86.4%   86.42%   +0.01%     
==========================================
  Files         319      319              
  Lines       10453    10453              
  Branches      351      561     +210     
==========================================
+ Hits         9032     9034       +2     
+ Misses       1421     1419       -2
Impacted Files Coverage Δ
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c06124...a7c4c9a. Read the comment docs.

tovbinm
tovbinm reviewed Apr 16, 2019
View reviewed changes
...src/test/scala/com/salesforce/op/stages/impl/feature/OPCollectionHashingVectorizerTest.scala Outdated
class OPCollectionHashingVectorizerTest extends OpTransformerSpec[OPVector, OPCollectionHashingVectorizer[TextList]]
with AttributeAsserts {

val (dataList, f1) =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

val (inputData, f1) = ...

tovbinm
tovbinm approved these changes Apr 16, 2019
View reviewed changes
Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , see one minor comment

@wsuchy wsuchy merged commit 699f978 into master Apr 16, 2019
@tovbinm tovbinm deleted the ks/improved-tests-OPCollectionHashingVectorizerTest branch April 17, 2019 22:14
@Jauntbox Jauntbox mentioned this pull request May 2, 2019
Merged
@michaelweilsalesforce michaelweilsalesforce mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tovbinm tovbinm tovbinm approved these changes

@leahmcguire leahmcguire Awaiting requested review from leahmcguire leahmcguire is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wsuchy @tovbinm