Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rawPrediction of OpXGBoostClassifcationModel for binary classification #229

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

kinfaikan
Copy link
Contributor

Related issues
NA

Describe the proposed solution
OpXGBoostClassificationModel outputs only one raw prediction value for binary classification and causes ArrayIndexOutOfBoundsException in BinaryClassificationEvaluator. Modify OpXGBoostClassificationModel to generate two raw prediction values for binary classification.

Describe alternatives you've considered
NA

Additional context
NA

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #229 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   86.41%   86.39%   -0.02%     
==========================================
  Files         312      312              
  Lines       10182    10183       +1     
  Branches      333      564     +231     
==========================================
- Hits         8799     8798       -1     
- Misses       1383     1385       +2
Impacted Files Coverage Δ
...ages/impl/classification/OpXGBoostClassifier.scala 32.75% <100%> (+1.17%) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a893747...9246da8. Read the comment docs.

@tovbinm tovbinm merged commit bfc8312 into master Feb 19, 2019
@tovbinm tovbinm deleted the kk/xgboost branch February 19, 2019 20:29
@alexnikitchuk
Copy link

Hey @tovbinm do you have a plan to release this fix?

@tovbinm
Copy link
Collaborator

tovbinm commented Mar 29, 2019

Yes, we are planning to make a release within the next few weeks.

For now, you can publish from master locally.

@tovbinm tovbinm mentioned this pull request Apr 10, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants