Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 5.2 #218

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Upgrade to Gradle 5.2 #218

merged 2 commits into from
Feb 7, 2019

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Feb 7, 2019

Related issues
NA

Describe the proposed solution
Upgrading to newer Gradle 5.2 with latest functionality of Maven publishing. Additionally upgraded to latest scoverage plugin 2.5.0.

Describe alternatives you've considered
NA

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #218 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files         310      310           
  Lines       10137    10137           
  Branches      348      347    -1     
=======================================
  Hits         8755     8755           
  Misses       1382     1382
Impacted Files Coverage Δ
...e/op/stages/impl/insights/RecordInsightsLOCO.scala 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eaf5bc...25a0203. Read the comment docs.

Copy link
Contributor

@Jauntbox Jauntbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tovbinm tovbinm merged commit b8328db into master Feb 7, 2019
@tovbinm tovbinm deleted the mt/gradle-5.2 branch February 7, 2019 21:45
@tovbinm tovbinm restored the mt/gradle-5.2 branch February 7, 2019 21:45
@tovbinm tovbinm deleted the mt/gradle-5.2 branch February 7, 2019 21:45
@Jauntbox Jauntbox mentioned this pull request Feb 8, 2019
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
@salesforce-cla
Copy link

salesforce-cla bot commented Nov 2, 2020

Thanks for the contribution! Before we can merge this, we need @Jauntbox to sign the Salesforce.com Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants