-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI build for HelloWorld #210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
========================================
- Coverage 86.39% 0% -86.4%
========================================
Files 310 310
Lines 10136 316 -9820
Branches 351 15 -336
========================================
- Hits 8757 0 -8757
+ Misses 1379 316 -1063
Continue to review full report at Codecov.
|
@tovbinm is this a bug in the test case? https://travis-ci.com/salesforce/TransmogrifAI/jobs/171776690 |
@rajdeepd it's not running the helloworld build yet. The results seems to be from the regular build. |
@tovbinm is there something else I need to add or this will suffice. |
@rajdeepd we have two options here:
I think the second option is preferred, cause you would be able to test it locally and we wont need to replicate the CI build configs into helloworld project. Does it make sense? |
@rajdeepd please also read https://docs.travis-ci.com/user/tutorial/ and https://circleci.com/docs/2.0/tutorials/ |
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 86.39% 82.33% -4.07%
==========================================
Files 310 310
Lines 10136 10136
Branches 351 548 +197
==========================================
- Hits 8757 8345 -412
- Misses 1379 1791 +412
Continue to review full report at Codecov.
|
@tovbinm yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajdeepd lgtm! please also update the TravisCI build config.
@tovbinm sure! |
Thank you @rajdeepd Looking forward to it ;) |
Thanks for the contribution! Before we can merge this, we need @rajdeepd to sign the Salesforce.com Contributor License Agreement. |
Related issues
#114
Describe the proposed solution
Created a new circleci based configuration which checks for scalastyle and testcoverage
Describe alternatives you've considered
It will be easier for helloworld to have its own CI build.
Additional context
none