Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build for HelloWorld #210

Merged
merged 7 commits into from
Jan 26, 2019
Merged

CI build for HelloWorld #210

merged 7 commits into from
Jan 26, 2019

Conversation

rajdeepd
Copy link
Contributor

Related issues
#114

Describe the proposed solution
Created a new circleci based configuration which checks for scalastyle and testcoverage

Describe alternatives you've considered
It will be easier for helloworld to have its own CI build.

Additional context
none

@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #210 into master will decrease coverage by 86.39%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #210      +/-   ##
========================================
- Coverage   86.39%     0%   -86.4%     
========================================
  Files         310    310              
  Lines       10136    316    -9820     
  Branches      351     15     -336     
========================================
- Hits         8757      0    -8757     
+ Misses       1379    316    -1063
Impacted Files Coverage Δ
...cala/com/salesforce/op/OpWorkflowModelWriter.scala 0% <0%> (-100%) ⬇️
...orce/op/stages/impl/feature/MimeTypeDetector.scala 0% <0%> (-100%) ⬇️
...sforce/op/stages/base/binary/BinaryEstimator.scala 0% <0%> (-100%) ⬇️
...la/com/salesforce/op/aggregators/Geolocation.scala 0% <0%> (-100%) ⬇️
.../stages/impl/feature/OpStringIndexerNoFilter.scala 0% <0%> (-100%) ⬇️
...orce/op/stages/impl/feature/BinaryVectorizer.scala 0% <0%> (-100%) ⬇️
...ala/com/salesforce/op/testkit/InfiniteStream.scala 0% <0%> (-100%) ⬇️
...esforce/op/stages/impl/feature/TextTokenizer.scala 0% <0%> (-100%) ⬇️
...la/com/salesforce/op/utils/io/avro/AvroInOut.scala 0% <0%> (-100%) ⬇️
...rce/op/stages/impl/feature/JaccardSimilarity.scala 0% <0%> (-100%) ⬇️
... and 272 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b195b...98551c9. Read the comment docs.

@rajdeepd
Copy link
Contributor Author

@tovbinm is this a bug in the test case? https://travis-ci.com/salesforce/TransmogrifAI/jobs/171776690

@tovbinm
Copy link
Collaborator

tovbinm commented Jan 23, 2019

@rajdeepd it's not running the helloworld build yet. The results seems to be from the regular build.

@rajdeepd
Copy link
Contributor Author

@tovbinm is there something else I need to add or this will suffice.

@tovbinm
Copy link
Collaborator

tovbinm commented Jan 24, 2019

@rajdeepd we have two options here:

  1. configure helloworld as a separate build on Travis & Circle CI (this is what you started to do) by adding build configs.
  2. include helloworld build as part of the regular build (by modifying the build.gradle file in the root project). we can add a extra task that execute helloworld builds, which we will use on CI. E.g.:
./gradlew reportScoverage && ./gradlew publishToMavenLocal && ./gradlew buildHelloworld

I think the second option is preferred, cause you would be able to test it locally and we wont need to replicate the CI build configs into helloworld project.

Does it make sense?

@tovbinm
Copy link
Collaborator

tovbinm commented Jan 24, 2019

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #210 into master will decrease coverage by 4.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
- Coverage   86.39%   82.33%   -4.07%     
==========================================
  Files         310      310              
  Lines       10136    10136              
  Branches      351      548     +197     
==========================================
- Hits         8757     8345     -412     
- Misses       1379     1791     +412
Impacted Files Coverage Δ
...alesforce/op/cli/gen/templates/SimpleProject.scala 0% <0%> (-100%) ⬇️
.../scala/com/salesforce/op/cli/gen/ProblemKind.scala 0% <0%> (-100%) ⬇️
...cala/com/salesforce/op/cli/gen/FileInProject.scala 0% <0%> (-100%) ⬇️
.../salesforce/op/features/FeatureBuilderMacros.scala 0% <0%> (-100%) ⬇️
...in/scala/com/salesforce/op/cli/CommandParser.scala 0% <0%> (-98.12%) ⬇️
...cala/com/salesforce/op/cli/gen/ProblemSchema.scala 0% <0%> (-96.56%) ⬇️
...src/main/scala/com/salesforce/op/cli/gen/Ops.scala 0% <0%> (-94%) ⬇️
...ain/scala/com/salesforce/op/cli/SchemaSource.scala 0% <0%> (-87.94%) ⬇️
...a/com/salesforce/op/cli/gen/ProjectGenerator.scala 0% <0%> (-87.5%) ⬇️
...in/scala/com/salesforce/op/cli/CliParameters.scala 0% <0%> (-80.96%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b195b...78aa8d1. Read the comment docs.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@rajdeepd
Copy link
Contributor Author

@rajdeepd we have two options here:

  1. configure helloworld as a separate build on Travis & Circle CI (this is what you started to do) by adding build configs.
  2. include helloworld build as part of the regular build (by modifying the build.gradle file in the root project). we can add a extra task that execute helloworld builds, which we will use on CI. E.g.:
./gradlew reportScoverage && ./gradlew publishToMavenLocal && ./gradlew buildHelloworld

I think the second option is preferred, cause you would be able to test it locally and we wont need to replicate the CI build configs into helloworld project.

Does it make sense?

@tovbinm yes

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajdeepd lgtm! please also update the TravisCI build config.

@tovbinm tovbinm merged commit 6ee7cc7 into salesforce:master Jan 26, 2019
@rajdeepd
Copy link
Contributor Author

@tovbinm sure!

@tovbinm
Copy link
Collaborator

tovbinm commented Feb 1, 2019

Thank you @rajdeepd Looking forward to it ;)

@Jauntbox Jauntbox mentioned this pull request Feb 8, 2019
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
@salesforce-cla
Copy link

salesforce-cla bot commented Dec 1, 2020

Thanks for the contribution! Before we can merge this, we need @rajdeepd to sign the Salesforce.com Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants