Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cases for RichListFeature #207

Closed
wants to merge 5 commits into from
Closed

Conversation

rajdeepd
Copy link
Contributor

Related issues
None

Describe the proposed solution
This pull request helps improve code coverage and unit testing for RichListFeature

Describe alternatives you've considered
none

Additional context
This is first of series of commits i am planning to make

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Rajdeep <r***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

@salesforce-cla
Copy link

Thanks for the contribution! It looks like @rajdeepd is an internal user so signing the CLA is not required. However, we need to confirm this.

@rajdeepd
Copy link
Contributor Author

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Rajdeep <r***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Added email id to the github account

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #207 into master will decrease coverage by 18.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #207       +/-   ##
===========================================
- Coverage   86.36%   68.22%   -18.15%     
===========================================
  Files         310      310               
  Lines       10132    10132               
  Branches      353      530      +177     
===========================================
- Hits         8751     6913     -1838     
- Misses       1381     3219     +1838
Impacted Files Coverage Δ
...ce/op/stages/impl/feature/TextLenTransformer.scala 0% <0%> (-100%) ⬇️
...lesforce/op/stages/impl/feature/LangDetector.scala 0% <0%> (-100%) ⬇️
...alesforce/op/cli/gen/templates/SimpleProject.scala 0% <0%> (-100%) ⬇️
...main/scala/com/salesforce/op/filters/Summary.scala 0% <0%> (-100%) ⬇️
.../scala/com/salesforce/op/cli/gen/ProblemKind.scala 0% <0%> (-100%) ⬇️
...orce/op/stages/impl/feature/RealNNVectorizer.scala 0% <0%> (-100%) ⬇️
...cala/com/salesforce/op/cli/gen/FileInProject.scala 0% <0%> (-100%) ⬇️
...p/stages/impl/feature/OpScalarStandardScaler.scala 0% <0%> (-100%) ⬇️
.../salesforce/op/features/FeatureBuilderMacros.scala 0% <0%> (-100%) ⬇️
...ages/impl/regression/RegressionModelSelector.scala 0% <0%> (-98.12%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4c42c...c458d2c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #207 into master will decrease coverage by 12.71%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #207       +/-   ##
===========================================
- Coverage   82.37%   69.65%   -12.72%     
===========================================
  Files         310      310               
  Lines       10132    10136        +4     
  Branches      530      546       +16     
===========================================
- Hits         8346     7060     -1286     
- Misses       1786     3076     +1290
Impacted Files Coverage Δ
...in/scala/com/salesforce/op/cli/CommandParser.scala 98.11% <100%> (+98.11%) ⬆️
...cala/com/salesforce/op/cli/gen/ProblemSchema.scala 96.55% <100%> (+96.55%) ⬆️
...src/main/scala/com/salesforce/op/cli/CliExec.scala 80% <100%> (+80%) ⬆️
...sforce/op/stages/base/binary/BinaryEstimator.scala 0% <0%> (-100%) ⬇️
...la/com/salesforce/op/aggregators/Geolocation.scala 0% <0%> (-100%) ⬇️
...ala/com/salesforce/op/testkit/InfiniteStream.scala 0% <0%> (-100%) ⬇️
.../salesforce/op/aggregators/FeatureAggregator.scala 0% <0%> (-100%) ⬇️
...stages/base/sequence/BinarySequenceEstimator.scala 0% <0%> (-100%) ⬇️
...rce/op/stages/OpPipelineStageReadWriteShared.scala 0% <0%> (-100%) ⬇️
...ages/base/sequence/BinarySequenceTransformer.scala 0% <0%> (-100%) ⬇️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d94737...040ada1. Read the comment docs.

@amateurhuman
Copy link

@rajdeepd you've been invited to the Salesforce org, once you accept the invitation you can refresh this PR by going to https://cla.salesforce.com/status/salesforce/TransmogrifAI/pull/207 to clear the CLA check

@tovbinm
Copy link
Collaborator

tovbinm commented Jan 12, 2019

@rajdeepd Thanks for the contribution. I am not sure how this improves the coverage, as based on the metrics it seems to drop.
In any case, tf() is tested in HashingTFTest and idf() is tested in IDFTest. I can recommend you some other tasks if you'd like, hmm?

@rajdeepd
Copy link
Contributor Author

rajdeepd commented Jan 18, 2019

Sure @tovbinm let me know where you need help, though i am new to this code base.

@tovbinm
Copy link
Collaborator

tovbinm commented Jan 18, 2019

@rajdeepd how about this? #114

@rajdeepd rajdeepd closed this Jan 19, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants