-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test cases for RichListFeature #207
Conversation
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Rajdeep <r***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
Thanks for the contribution! It looks like @rajdeepd is an internal user so signing the CLA is not required. However, we need to confirm this. |
Added email id to the github account |
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
===========================================
- Coverage 86.36% 68.22% -18.15%
===========================================
Files 310 310
Lines 10132 10132
Branches 353 530 +177
===========================================
- Hits 8751 6913 -1838
- Misses 1381 3219 +1838
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
===========================================
- Coverage 82.37% 69.65% -12.72%
===========================================
Files 310 310
Lines 10132 10136 +4
Branches 530 546 +16
===========================================
- Hits 8346 7060 -1286
- Misses 1786 3076 +1290
Continue to review full report at Codecov.
|
@rajdeepd you've been invited to the Salesforce org, once you accept the invitation you can refresh this PR by going to https://cla.salesforce.com/status/salesforce/TransmogrifAI/pull/207 to clear the CLA check |
@rajdeepd Thanks for the contribution. I am not sure how this improves the coverage, as based on the metrics it seems to drop. |
Sure @tovbinm let me know where you need help, though i am new to this code base. |
Related issues
None
Describe the proposed solution
This pull request helps improve code coverage and unit testing for RichListFeature
Describe alternatives you've considered
none
Additional context
This is first of series of commits i am planning to make