Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow convertion from Date and Timestamp Spark types to Date and DateTime TransmogrifAI types #188

Merged
merged 4 commits into from
Dec 1, 2018

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Dec 1, 2018

Related issues
This bug was discovered and reported through Gitter by @msouder

Describe the proposed solution
Added specific cases for java.util.Date value conversions in FeatureTypeSparkConverter for Date and DateTime

Describe alternatives you've considered
N/A

@codecov
Copy link

codecov bot commented Dec 1, 2018

Codecov Report

Merging #188 into master will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   86.31%   86.35%   +0.04%     
==========================================
  Files         307      307              
  Lines        9971     9975       +4     
  Branches      336      551     +215     
==========================================
+ Hits         8606     8614       +8     
+ Misses       1365     1361       -4
Impacted Files Coverage Δ
...com/salesforce/op/features/FeatureSparkTypes.scala 96.12% <100%> (ø) ⬆️
.../op/features/types/FeatureTypeSparkConverter.scala 98.19% <80%> (-0.87%) ⬇️
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️
.../salesforce/op/features/FeatureBuilderMacros.scala 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46b5a5...54f6e96. Read the comment docs.

@tovbinm tovbinm merged commit 3948691 into master Dec 1, 2018
@tovbinm tovbinm deleted the mt/date-features branch December 1, 2018 20:31
@Jauntbox Jauntbox mentioned this pull request Feb 8, 2019
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant