Fix #3087 Report calculate totals for all records

[abuzarfaris]

Description

Report now calculates summary for all records not just current page records

Motivation and Context

How To Test This

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[serhiisamko091184]

Hello @abuzarfaris ,
thanks for your contribution!

Regards,
Serhii

[clemente-raposo]

@serhiisamko091184 the file needs some re-formatting according to our internal standards

[serhiisamko091184]

Hello @abuzarfaris,

thanks for your PR,

could you please reformat the code you've provided (this is mostly about spaces all over the code lines) and re-push it?

Many thanks in advance!

Regards,
Serhii

[abuzarfaris]

Hello @abuzarfaris,

thanks for your PR,

could you please reformat the code you've provided (this is mostly about spaces all over the code lines) and re-push it?

Many thanks in advance!

Regards, Serhii

Hey @serhiisamko091184 can you please elaborate more about which white spaces you need changed.
I have just added these following sections to the code

[serhiisamko091184]

Thanks for your quick response,

Yes, sure:

1. 'if' structures have a different formatting;
2. different quotes in use;
3. spaces to be removed and added across the sections.

Thanks a lot!

Regards,
Serhii

[abuzarfaris]

Thanks for your quick response,

Yes, sure:

1. 'if' structures have a different formatting;
2. different quotes in use;
3. spaces to be removed and added across the sections.

Thanks a lot!

Regards, Serhii

@serhiisamko091184 hey thank you very much I now understand your requests

[abuzarfaris]

@serhiisamko091184 I have updated the commit please review

[serhiisamko091184]

Hello @abuzarfaris,

thank you for the changes you've made, I appreciate your quick reply,

on the formatting: would you be so kind to make if/else control structure consistent with the rest of the code by moving 'else' line to the closing figure brace of the 'if' part (L991)?

Apart from the formatting, I'd like to draw your attention to the commented line 979:

If we don't need to use it, we could remove the line.

Thanks a lot!

Regards,
Serhii

[abuzarfaris]

Hello @abuzarfaris,

thank you for the changes you've made, I appreciate your quick reply,

on the formatting: would you be so kind to make if/else control structure consistent with the rest of the code by moving 'else' line to the closing figure brace of the 'if' part (L991)?

Apart from the formatting, I'd like to draw your attention to the commented line 979:

If we don't need to use it, we could remove the line.

Thanks a lot!

Regards, Serhii

@serhiisamko091184 thank you for the detailed guidance. I have updated the commit

[serhiisamko091184]

Thanks again for the contributing, @abuzarfaris!

[johnM2401]

Hey!
I've had a test of this PR locally and it appears as though Reports now has some odd field rendering issues.

I've noticed that any fields after an "Average" or "Sum" are totally dropped.

The user should be able to see all fields set on the report.

See screenshots:

In these two, I have 4 Amount fields in order of: None/Count/Average/Sum
However, Sum no longer renders

If I reorder these fields so that Sum comes before Average and Count, only Sum shows:

And as another example, setting average as the first field, it is the only field that renders:

For example, before this fix, it renders all 3:

Is this something that you've come across in your usage? (I assume this is not intentional, so want to double check this isn't something on my end)
Would you be able to have a look into this, if you get a chance?

Thanks!

[abuzarfaris]

Hey! I've had a test of this PR locally and it appears as though Reports now has some odd field rendering issues.

I've noticed that any fields after an "Average" or "Sum" are totally dropped.

The user should be able to see all fields set on the report.

See screenshots:

In these two, I have 4 Amount fields in order of: None/Count/Average/Sum However, Sum no longer renders

If I reorder these fields so that Sum comes before Average and Count, only Sum shows:

And as another example, setting average as the first field, it is the only field that renders:

For example, before this fix, it renders all 3:

Is this something that you've come across in your usage? (I assume this is not intentional, so want to double check this isn't something on my end) Would you be able to have a look into this, if you get a chance?

Thanks!

Hey can you tell me your php version as well I'll test with similar version thank you

[johnM2401]

Hey can you tell me your php version as well I'll test with similar version thank you

Hey @abuzarfaris !
Ah apologies, I'd tested it on:
Firefox 113.0.2 / PHP8.2.11 / MariaDB 10.4.12 / SuiteCRM version 7.14.4

(I've just double checked there and am able to replicate on PHP7.4 / Chromium 125)

Let me know if you need any more information!
Thanks again!

[abuzarfaris]

Hey can you tell me your php version as well I'll test with similar version thank you

Hey @abuzarfaris ! Ah apologies, I'd tested it on: Firefox 113.0.2 / PHP8.2.11 / MariaDB 10.4.12 / SuiteCRM version 7.14.4

(I've just double checked there and am able to replicate on PHP7.4 / Chromium 125)

Let me know if you need any more information! Thanks again!

@johnM2401 Thank you very much for pointing out the issue. I have updated the commit to resolve the issue

[johnM2401]

Thank you @abuzarfaris
Latest fix looks good, report content rendering appears to match how it was before.
(With "Total" functions working across all pages, now)

Thank you again for your contribution!