Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator for required field name in attribute bulk mutations 3.17 #16177

Merged

Conversation

zedzior
Copy link
Member

@zedzior zedzior commented Jun 19, 2024

Port: #16166

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

@zedzior zedzior self-assigned this Jun 19, 2024
@db-queries
Copy link

db-queries bot commented Jun 19, 2024

Here is the report for e7cea05 (saleor:merx-6-add-name-check-to-attribute-bulk-mutations-3.17)
Missing base report (93f06a7). The results couldn't be compared.

No differences were found.

@zedzior zedzior merged commit 1980768 into 3.17 Jun 19, 2024
10 checks passed
@zedzior zedzior deleted the merx-6-add-name-check-to-attribute-bulk-mutations-3.17 branch June 19, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants