Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing products boolean filter #16148

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

korycins
Copy link
Member

I want to merge this change because it fixes the case when filtering via the boolean attribute, that doesn't exist on Saleor side.

{
  products(
    first: 12
    channel: "default-channel"
    filter: {attributes: {slug: "bb", boolean: true}}
  ) {
    edges {
      node {
        id
      }
    }
  }
}

Could raise an unhandled exception when bb attribute doesn't exist.

Covers https://linear.app/saleor/issue/MERX-417/passing-non-existing-attribute-slug-crashes-product-filtering

Port of changes from: #16112

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

@korycins korycins added the 3.16 label Jun 14, 2024
@korycins korycins self-assigned this Jun 14, 2024
@db-queries
Copy link

db-queries bot commented Jun 14, 2024

Here is the report for 6ff4e06 (saleor:fix-failing-product-boolean-filter-3-16)
Missing base report (d6dc5af). The results couldn't be compared.

No differences were found.

@korycins korycins marked this pull request as ready for review June 17, 2024 10:25
@korycins korycins requested a review from a team June 17, 2024 10:25
@8r2y5 8r2y5 requested a review from a team June 17, 2024 10:29
@korycins korycins merged commit c2f7785 into 3.16 Jun 19, 2024
7 checks passed
@korycins korycins deleted the fix-failing-product-boolean-filter-3-16 branch June 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants