Feature/saleor 1564 Add next.js to the Storefront #960
Conversation
… into feature/SALEOR-1563-nextjs-integration
… into feature/SALEOR-1563-nextjs-integration
|
Task linked: SALEOR-1564 Add next.js to the Storefront |
piotrgrundas
force-pushed
the
feature/SALEOR-1564-add-next-js
branch
from
fe71869
to
62629fc
Compare
| }, | ||
| "exclude": ["node_modules"], | ||
| "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"] |
There was a problem hiding this comment.
Next modifies tsconfig on the first run 🤷♂️
| } | ||
| }); | ||
| return history; | ||
| })() as History; |
There was a problem hiding this comment.
Temporary hack so checkout could work with react router.
| if (target) { | ||
| setPortalTarget(target); | ||
| } | ||
| }, [target]); |
There was a problem hiding this comment.
Needed coz of SSR build.
| * /\?(.+&)?no-cache=1$/, | ||
| * ], | ||
| * Or NetworkOnly might have the same effect. | ||
| */ |
There was a problem hiding this comment.
I'll get back to this after some SSR work to validate it, so I would like to leave it for now.
|
This pull request introduces 1 alert when merging 62629fc into 1abbf68 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging bb5eeab into 1abbf68 - view on LGTM.com new alerts:
|
piotrgrundas
force-pushed
the
feature/SALEOR-1564-add-next-js
branch
from
bb5eeab
to
7fb1a22
Compare
piotrgrundas
force-pushed
the
feature/SALEOR-1564-add-next-js
branch
from
7fb1a22
to
e5b6c22
Compare
|
This pull request introduces 1 alert when merging e5b6c22 into 1abbf68 - view on LGTM.com new alerts:
|
src/@next/components/atoms/RichTextEditorContent/RichTextEditorContent.tsx
Show resolved
Hide resolved
|
Minor things to change, rest is looking good 👍 |
|
This pull request introduces 1 alert when merging 218f99d into 1abbf68 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 062a7dc into 1abbf68 - view on LGTM.com new alerts:
|
piotrgrundas
force-pushed
the
feature/SALEOR-1564-add-next-js
branch
from
062a7dc
to
2032ff1
Compare
|
This pull request introduces 1 alert when merging 2032ff1 into 1abbf68 - view on LGTM.com new alerts:
|
* Feature/saleor 1564 Add next.js to the Storefront (#960) * Initial structure * Adjust product page * Adjust login page * Adjust product, category, collection, cart pages * Adjust pages, account confirm, reset password views * Adjust search, account views. Checkout first adjustments * Adjust pages, account confirm, reset password views * Fix problems after rebase * Fix problems after rebase, add env files * Fix channels, checkout. Improve envs setup * Cleanup settings, split them into separate configurations, add sw config * Cleanup paths hell 🔥 * Fix storybook * Fix tests, minor improvements * Prod config styles fix * Review corrections * Adjust tests/storybook after account paths matching improvements * Switch checkout to nextjs routing (#967) * Switch checkout to nextjs routing * Improvements * Add prod export sw config * Refactor service worker * Fix sw for static pages & production serwer * Review corrections * Improvements * Review corrections * Review corrections * Update src/@next/pages/CheckoutPage/utils.tsx Co-authored-by: Jakub Majorek <[email protected]> * Remove unused imports Co-authored-by: Jakub Majorek <[email protected]> * Adjust build commands, fix tsc errors * Improvements * Add dynamic routes+export workaround * Update .github/workflows/test-env-deploy.yml Co-authored-by: Krzysztof Wolski <[email protected]> Co-authored-by: Jakub Majorek <[email protected]> Co-authored-by: Krzysztof Wolski <[email protected]>
I want to merge this change because...
Add next.js to the Storefront
Screenshots
Pull Request Checklist
Test Environment Config
API_URI=https://master.staging.saleor.rocks/graphql/