Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 #284

Open
wants to merge 99 commits into
base: main
Choose a base branch
from
Open

Version 3 #284

wants to merge 99 commits into from

Conversation

saleem-hadad
Copy link
Owner

@saleem-hadad saleem-hadad commented Sep 2, 2021

#58 and #252

Current approach
[WIP]

Proposed approach
Untitled Diagram

Open discussion and tech discovery:

  1. I've tried to implement the decorator pattern around caching and actual implementation. However, I think this might be a bit difficult and might introduce buggy behaviour when extending/replacing the core file fetching functionality. Therefore, I'm considering cache as a separate extendable/replaceable layer without interfering with the core logic of fetching from the file system.
  2. The proposed approach allows source agnostic (i.e replacing file system with DB in a separate package for example)

Breaking changes:

extracted packages

  • LaRecipeTracking
  • LaRecipeSearch

@saleem-hadad saleem-hadad added this to In progress in Version 3 Aug 20, 2022
@jannismilz
Copy link

@saleem-hadad are you still working on Version 3?

@saleem-hadad
Copy link
Owner Author

yes @jannismilz
sorry I had a few hiccups along the way with life but sure coming back soon +1

@jannismilz
Copy link

@saleem-hadad alright awesome! I was a bit worried about if LaRecipe is still getting maintained, I currently use it to write documentation and I really like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Version 3
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants