Skip to content

Commit

Permalink
[receive/jmx] fix lint for jmxreceiver (open-telemetry#12204)
Browse files Browse the repository at this point in the history
Signed-off-by: Ziqi Zhao <[email protected]>
  • Loading branch information
fatsheep9146 committed Jul 11, 2022
1 parent 4e68fd8 commit 32d8141
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions receiver/jmxreceiver/internal/subprocess/subprocess.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// nolint:errcheck,gocritic
package subprocess // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/jmxreceiver/internal/subprocess"

import (
Expand Down Expand Up @@ -258,7 +257,7 @@ func (subprocess *Subprocess) run(ctx context.Context) {
}
case shuttingDown:
if cmd.Process != nil {
cmd.Process.Signal(syscall.SIGTERM)
_ = cmd.Process.Signal(syscall.SIGTERM)
}
<-processReturned.ReturnedChan
stdout.Close()
Expand Down Expand Up @@ -305,7 +304,8 @@ func createCommand(execPath string, args, envVars []string) (*exec.Cmd, io.Write

var env []string
env = append(env, os.Environ()...)
cmd.Env = append(env, envVars...)
env = append(env, envVars...)
cmd.Env = env

inReader, inWriter, err := os.Pipe()
if err != nil {
Expand Down

0 comments on commit 32d8141

Please sign in to comment.