GNOME 46 compatibility #136

ChrisLauinger77 · 2024-02-11T09:28:41Z

gnome 46 is in beta which means interfaces are frozen - I updated already the 3 other extensions I maintain.
one thing i noticed is they removed add_actor / remove_actor in favor of add_child / remove_child

ChrisLauinger77 · 2024-02-11T09:29:49Z

Currently it is not working- log message:

[Media Controls] Error: Failed to call listener for property PlaybackStatus: TypeError: this.menuControls.find_child_by_name is not a function
                                             addMenuControlIcon@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:514:43
                                             addMenuControls@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:467:18
                                             updateWidgets@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:140:18
                                             PanelButton@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:48:14
                                             addPanelButton@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/extension.js:460:25
                                             setActivePlayer@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/extension.js:417:22
                                             callOnChangedListeners@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PlayerProxy.js:118:25
                                             initPlayer/<@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PlayerProxy.js:37:22
                                             _callHandlers@resource:https:///org/gnome/gjs/modules/core/_signals.js:130:42
                                             _emit@resource:https:///org/gnome/gjs/modules/core/_signals.js:119:10
                                             _convertToNativeSignal@resource:https:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
                                             @resource:https:///org/gnome/shell/ui/init.js:21:20

ChrisLauinger77 · 2024-02-11T09:32:12Z

@sakithb lets work here to get it running on GNOME46

sakithb · 2024-02-11T12:06:04Z

Have they released a list of API changes yet?

sakithb · 2024-02-11T12:06:57Z

Currently it is not working- log message:

[Media Controls] Error: Failed to call listener for property PlaybackStatus: TypeError: this.menuControls.find_child_by_name is not a function
                                             addMenuControlIcon@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:514:43
                                             addMenuControls@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:467:18
                                             updateWidgets@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:140:18
                                             PanelButton@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:48:14
                                             addPanelButton@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/extension.js:460:25
                                             setActivePlayer@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/extension.js:417:22
                                             callOnChangedListeners@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PlayerProxy.js:118:25
                                             initPlayer/<@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PlayerProxy.js:37:22
                                             _callHandlers@resource:https:///org/gnome/gjs/modules/core/_signals.js:130:42
                                             _emit@resource:https:///org/gnome/gjs/modules/core/_signals.js:119:10
                                             _convertToNativeSignal@resource:https:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
                                             @resource:https:///org/gnome/shell/ui/init.js:21:20

Seems like they have removed some functions

ChrisLauinger77 · 2024-02-11T13:10:07Z

Have they released a list of API changes yet?

Not yet - I was digging in their gitlab to get some info though.

ChrisLauinger77 · 2024-02-11T13:33:25Z

Currently it is not working- log message:

[Media Controls] Error: Failed to call listener for property PlaybackStatus: TypeError: this.menuControls.find_child_by_name is not a function
                                             addMenuControlIcon@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:514:43
                                             addMenuControls@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:467:18
                                             updateWidgets@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:140:18
                                             PanelButton@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PanelButton.js:48:14
                                             addPanelButton@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/extension.js:460:25
                                             setActivePlayer@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/extension.js:417:22
                                             callOnChangedListeners@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PlayerProxy.js:118:25
                                             initPlayer/<@file:https:///home/christian/.local/share/gnome-shell/extensions/[email protected]/helpers/shell/PlayerProxy.js:37:22
                                             _callHandlers@resource:https:///org/gnome/gjs/modules/core/_signals.js:130:42
                                             _emit@resource:https:///org/gnome/gjs/modules/core/_signals.js:119:10
                                             _convertToNativeSignal@resource:https:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
                                             @resource:https:///org/gnome/shell/ui/init.js:21:20

Seems like they have removed some functions

https://gjs-docs.gnome.org/clutter13~13/clutter.container#method-find_child_by_name
Still documented though - maybe a bug in beta - we will figure it out

ChrisLauinger77 · 2024-02-29T18:22:57Z

They released the guide

https://gjs.guide/extensions/upgrading/gnome-shell-46.html#metadata
Clutter.Container was removed. and all its props and methods with it.
any idea what can be a suiteable replacement ? see also my last commit

ChrisLauinger77 · 2024-02-29T20:05:53Z

have it working and the good news is it should work on both gnome 45 and 46
maybe you can help testing ?

sakithb · 2024-03-01T04:39:02Z

have it working and the good news is it should work on both gnome 45 and 46 maybe you can help testing ?

That's great. I will test it on my system and let you know

Clutter.Container was removed bumped versions

ChrisLauinger77 · 2024-03-02T09:27:13Z

I tested on both GNOME 45 & 46 - I had to update the commit for 45 compat.
Works on both for me and the changes are minor.
IMHO can be merged and released.

sakithb · 2024-03-05T16:14:19Z

Sorry, I've been busy the past few weeks, I will test it tomorrow. I can test on Arch.

sakithb · 2024-03-10T12:57:51Z

This freezed my desktop on startup, there were no logs as well. I tested on GNOME 45.4 on Arch Linux, did it work for you on 45?

ChrisLauinger77 · 2024-03-10T13:09:05Z

This freezed my desktop on startup, there were no logs as well. I tested on GNOME 45.4 on Arch Linux, did it work for you on 45?

I am using it on gnome 45 right now.
gnome-shell 45.3

sakithb · 2024-03-10T13:19:22Z

This freezed my desktop on startup, there were no logs as well. I tested on GNOME 45.4 on Arch Linux, did it work for you on 45?

I am using it on gnome 45 right now. gnome-shell 45.3

Nevermind it works now. Don't know why it freezed last time. Did you encounter the slider issue again?

ChrisLauinger77 · 2024-03-10T14:12:14Z

This freezed my desktop on startup, there were no logs as well. I tested on GNOME 45.4 on Arch Linux, did it work for you on 45?

I am using it on gnome 45 right now. gnome-shell 45.3

Nevermind it works now. Don't know why it freezed last time. Did you encounter the slider issue again?

I still have the slider workaround in - debian packages did not update yet

ChrisLauinger77 · 2024-03-10T15:16:07Z

GNOME 46 will be released 20th this month. We should release a new version in the next 10 days.

sakithb · 2024-03-10T16:24:19Z

I will do that.

ChrisLauinger77 requested a review from sakithb February 11, 2024 09:32

ChrisLauinger77 force-pushed the gnome46 branch 3 times, most recently from 2184457 to bea52a2 Compare February 29, 2024 20:01

ChrisLauinger77 marked this pull request as ready for review February 29, 2024 20:05

ChrisLauinger77 force-pushed the gnome46 branch 2 times, most recently from 49c5cee to 9b9bc50 Compare February 29, 2024 20:23

GNOME 46 compatibility

160771e

Clutter.Container was removed bumped versions

ChrisLauinger77 force-pushed the gnome46 branch from 9b9bc50 to 160771e Compare March 1, 2024 19:02

ChrisLauinger77 self-assigned this Mar 2, 2024

sakithb merged commit ab640a1 into main Mar 10, 2024
2 checks passed

sakithb deleted the gnome46 branch March 10, 2024 13:28

ChrisLauinger77 mentioned this pull request Mar 24, 2024

Not compatible with GNOME 46 #141

Closed

ChrisLauinger77 linked an issue Mar 24, 2024 that may be closed by this pull request

Not compatible with GNOME 46 #141

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GNOME 46 compatibility #136

GNOME 46 compatibility #136

ChrisLauinger77 commented Feb 11, 2024 •

edited

Loading

ChrisLauinger77 commented Feb 11, 2024

ChrisLauinger77 commented Feb 11, 2024

sakithb commented Feb 11, 2024

sakithb commented Feb 11, 2024

ChrisLauinger77 commented Feb 11, 2024

ChrisLauinger77 commented Feb 11, 2024

ChrisLauinger77 commented Feb 29, 2024 •

edited

Loading

ChrisLauinger77 commented Feb 29, 2024 •

edited

Loading

sakithb commented Mar 1, 2024

ChrisLauinger77 commented Mar 2, 2024 •

edited

Loading

sakithb commented Mar 5, 2024

sakithb commented Mar 10, 2024

ChrisLauinger77 commented Mar 10, 2024

sakithb commented Mar 10, 2024

ChrisLauinger77 commented Mar 10, 2024

ChrisLauinger77 commented Mar 10, 2024

sakithb commented Mar 10, 2024

GNOME 46 compatibility #136

GNOME 46 compatibility #136

Conversation

ChrisLauinger77 commented Feb 11, 2024 • edited Loading

ChrisLauinger77 commented Feb 11, 2024

ChrisLauinger77 commented Feb 11, 2024

sakithb commented Feb 11, 2024

sakithb commented Feb 11, 2024

ChrisLauinger77 commented Feb 11, 2024

ChrisLauinger77 commented Feb 11, 2024

ChrisLauinger77 commented Feb 29, 2024 • edited Loading

ChrisLauinger77 commented Feb 29, 2024 • edited Loading

sakithb commented Mar 1, 2024

ChrisLauinger77 commented Mar 2, 2024 • edited Loading

sakithb commented Mar 5, 2024

sakithb commented Mar 10, 2024

ChrisLauinger77 commented Mar 10, 2024

sakithb commented Mar 10, 2024

ChrisLauinger77 commented Mar 10, 2024

ChrisLauinger77 commented Mar 10, 2024

sakithb commented Mar 10, 2024

ChrisLauinger77 commented Feb 11, 2024 •

edited

Loading

ChrisLauinger77 commented Feb 29, 2024 •

edited

Loading

ChrisLauinger77 commented Feb 29, 2024 •

edited

Loading

ChrisLauinger77 commented Mar 2, 2024 •

edited

Loading