Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

App shortcut for creating new note #35

Merged
merged 2 commits into from
Apr 10, 2020
Merged

App shortcut for creating new note #35

merged 2 commits into from
Apr 10, 2020

Conversation

msasikanth
Copy link
Contributor

Fixes #1

@saket saket mentioned this pull request Apr 10, 2020
Closed
saket
saket suggested changes Apr 10, 2020
View reviewed changes
Copy link
Owner

@saket saket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @msasikanth, thanks!

androidApp/src/main/java/press/editor/EditorActivity.kt Show resolved Hide resolved
androidApp/src/main/java/press/ShortcutReceiver.kt Outdated Show resolved Hide resolved
androidApp/src/main/java/press/ShortcutReceiver.kt Outdated Show resolved Hide resolved
@saket
Copy link
Owner

saket commented Apr 10, 2020 •
edited
Loading

@msasikanth can you also check if your implementation suffers from this problem?

@msasikanth
Copy link
Contributor Author

@msasikanth can you also check if your implementation suffers from this problem?

This is seems to only happen in emulator, when I tested it on my pixel 3 it's working fine.

@saket
Copy link
Owner

saket commented Apr 10, 2020

@msasikanth good to know!

@msasikanth msasikanth requested a review from saket April 10, 2020 02:56
@msasikanth
Copy link
Contributor Author

I have addressed the PR feedback, but I didn't change the uuid4() in EditorActivity

@saket
Copy link
Owner

saket commented Apr 10, 2020

LGTM! The CI is failing because of something on master. I'll push a fix and then merge this.

@saket
Copy link
Owner

saket commented Apr 10, 2020

Done. Can you reroll?

@msasikanth
Copy link
Contributor Author

Done. Can you reroll?

Done

@saket saket merged commit cfb1f0e into saket:master Apr 10, 2020
@saket
Copy link
Owner

saket commented Apr 10, 2020

Thanks for adding this!

@msasikanth msasikanth deleted the sm/09/app-shortcut branch April 14, 2020 01:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saket saket Awaiting requested review from saket

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcut for creating new note
2 participants
@msasikanth @saket