Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust for GStreamer-1.0 #19

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Adjust for GStreamer-1.0 #19

merged 3 commits into from
Dec 5, 2023

Conversation

dcaliste
Copy link
Collaborator

@dcaliste dcaliste commented Dec 5, 2023

close #11

Still not tested.

@dcaliste dcaliste changed the title Draft: Try to adjust for GStreamer Try to adjust for GStreamer Dec 5, 2023
@dcaliste
Copy link
Collaborator Author

dcaliste commented Dec 5, 2023

Quickly tested, songs are playing and seeking is working.

Olf0
Olf0 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Olf0 Olf0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcaliste, thank you very much: This is looking excellent.

So I may also delete src/taglib and src/mytaglib, right?
Edit: Done by PR #22.

@Olf0 Olf0 mentioned this pull request Dec 5, 2023
Closed
@Olf0 Olf0 merged commit c7c795d into sailfishos-applications:devel Dec 5, 2023
1 check passed
Olf0 added a commit that referenced this pull request Dec 5, 2023
@Olf0
Delete src/taglib directory
551d389 
Obsoleted by PR #19 by @dcaliste
@Olf0 Olf0 mentioned this pull request Dec 5, 2023
Merged
Olf0 added a commit that referenced this pull request Dec 5, 2023
@Olf0
Delete src/mytaglib directory
38fe720 
Obsoleted by PR #19 by @dcaliste
Olf0 added a commit that referenced this pull request Dec 5, 2023
@Olf0
Delete lib directory
a63d6a4 
Obsoleted by PR #19 by @dcaliste
Olf0 added a commit that referenced this pull request Dec 5, 2023
@Olf0
Remove taglib and mytaglib (#22)
c39199c 
* Delete src/taglib directory
  Obsoleted by PR #19 by @dcaliste

* Delete src/mytaglib directory
  Obsoleted by PR #19 by @dcaliste

* Delete lib directory
  Obsoleted by PR #19 by @dcaliste
@Olf0 Olf0 changed the title Try to adjust for GStreamer Adjust for GStreamer-1.0 Dec 5, 2023
Olf0 added a commit that referenced this pull request Dec 5, 2023
@Olf0 @dcaliste
devel→master: Final commits for 0.3.0-rc1 (#23)
952fc82 
* [README.md] Description stub and History

* [.gitignore] Add missed space character in comment

* [README.md] Enhance table with screenshots

* [flowplayer.spec] Revert part of e11649d

* [build-on-tags.yml] Fix using the wrong action-branch for SFOS < 4.1.0 (#18)

* [README.md] Fix table rendering by inserting `&nbsp;'`s

* [README.md] Optimise table spans, again

* [README.md] Large screenshot subtitles

* [README.md] Final screenshots-table formatting fix-up …

…, hopefully.

* [flowplayer.spec] Do first release for years still without `Vendor` set

* [README.md] Use relative image links

* Update README.md with License link

* [README.md] Link issue, fix italicisation.

* [README.md] Fix link: https://app.transifex.com/olf/flowplayer-1

* Add missing QImage includes.

* Adjust calls for GStreamer 1.0 API.

* Remove internal taglib

* Use QStandardPaths instead of hardcoded paths.

* Adjust some icon sizes

* Remove `taglib` and `mytaglib` (#22)

* Delete src/taglib directory
  Obsoleted by PR #19 by @dcaliste

* Delete src/mytaglib directory
  Obsoleted by PR #19 by @dcaliste

* Delete lib directory
  Obsoleted by PR #19 by @dcaliste

* Update README.md to recent changes

* Update README.md

* [README.md] Fix spell'o

* [flowplayer.spec] Up `version`-`release` to 0.3.0-rc1

* Update flowplayer.changes for v0.3.0

* Update flowplayer.changes

---------

Co-authored-by: Damien Caliste <[email protected]>
@dcaliste
Copy link
Collaborator Author

dcaliste commented Dec 6, 2023

Sorry @Olf0 , I was busy yesterday evening. Yes, I think the internal taglib can be removed, as you did. In case there are some modifications CepiPerez did for the purposes of FlowPlayer, they can still be recovered and added upstream, since taglib is present in Sailfish, it's easier. Of course, it means it's not compatible with Harbour, but this can also be treated separately by bundling the SailfishOS version inside the RPM if needed.

@Olf0
Copy link
Contributor

Olf0 commented Dec 6, 2023 •
edited
Loading

Of course, it means it's not compatible with Harbour, but this can also be treated separately by bundling the SailfishOS version inside the RPM if needed.

Oh, this is an aspect I missed (spontaneously I only thought of the intention to replace the outdated taglib-1.7.2 SailfishOS provided back then) and this might have been another relevant reason, why CepiPerez copied the source tree of taglib-1.9.1.

In case there are some modifications CepiPerez did for the purposes of FlowPlayer, they can still be recovered and added upstream, …

I saw his own additions to taglib in the mytaglib directory, which partially substitutes files of taglib-1.9.1 but mostly adds new ones. As I did not expect these changes to work with a vastly newer version (i.e. taglib-1.11.1), have no idea if CepiPerez was the original author of the files in the mytaglib directory and if any of these changes have already been upstreamed, I removed this directory ad hoc together with the taglib one and the lib one (see PR #22), which contained a precompiled DLL (libmytaglib.so: no idea why / what for). In hindsight I may have been a little bit too "trigger happy" yesterday night, but as you stated, "they can still be recovered".

I had the impression that the taglib in FlowPlayer's source tree was the original taglib-1.9.1 (i.e. unaltered), but did not carry out any proper checks (e.g. downloading and diffing).

@CepiPerez, feel free to comment my wild guesswork WRT taglib and mytaglib in this message with a follow-up message, or leave it, if you lack the time, motivation etc.

dcaliste pushed a commit that referenced this pull request Dec 12, 2023
@Olf0 @dcaliste
Remove taglib and mytaglib (#22)
07a0328 
* Delete src/taglib directory
  Obsoleted by PR #19 by @dcaliste

* Delete src/mytaglib directory
  Obsoleted by PR #19 by @dcaliste

* Delete lib directory
  Obsoleted by PR #19 by @dcaliste
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olf0 Olf0 Olf0 approved these changes

Assignees

@dcaliste dcaliste

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not build due to missing gstreamer-devel-0.10
2 participants
@dcaliste @Olf0