Auto-referer header fixes #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL fragments and userinfo parts of the authority should not be included in the Referer header when `auto_referer` is enabled. Fixes #392
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
+ Coverage 79.41% 79.83% +0.41%
==========================================
Files 52 52
Lines 3119 3169 +50
==========================================
+ Hits 2477 2530 +53
+ Misses 642 639 -3
Continue to review full report at Codecov.
|
sagebind
changed the title
sagebind
added a commit
that referenced
this pull request
May 13, 2022
Fix various aspects of the `auto_referer` option: - Fix multiple `Referer` headers being included when two or more redirects are followed in a request - URL fragments and userinfo parts of the authority should not be included in the `Referer` header - Don't include a `Referer` header when redirecting from an HTTPS URL to an HTTP URL, as per [RFC 7231](https://httpwg.org/specs/rfc7231.html#header.referer) recommendation - Scrub sensitive headers when redirecting to a different authority Fixes #392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various aspects of the
auto_refereroption:Refererheaders being included when two or more redirects are followed in a requestRefererheaderRefererheader when redirecting from an HTTPS URL to an HTTP URL, as per RFC 7231 recommendationFixes #392