Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preallocate buffer for async json decoding #367

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

michalmuskala
Copy link
Contributor

This is already done for bytes, and should speed up async JSON processing
considerably, avoiding needles reallocations.

This is already done for bytes, and should speed up async JSON processing
considerably, avoiding needles reallocations.
@sagebind
Copy link
Owner

Thanks!

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #367 (34657fe) into master (b886d3c) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   79.37%   79.34%   -0.04%     
==========================================
  Files          51       51              
  Lines        3060     3060              
==========================================
- Hits         2429     2428       -1     
- Misses        631      632       +1     
Impacted Files Coverage Δ
src/response.rs 68.51% <71.42%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b886d3c...34657fe. Read the comment docs.

@sagebind sagebind added the performance An enhancement or problem with performance label Dec 20, 2021
@sagebind sagebind merged commit 92cbf92 into sagebind:master Dec 20, 2021
@michalmuskala michalmuskala deleted the preallocate-json branch December 20, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance An enhancement or problem with performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants