Add bytes convenience methods #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `bytes` method to `ReadResponseExt` and `AsyncReadResponseExt`. These convenience methods are similar to the `text` methods without text decoding involved. These can make some uses more concise, and also take care of reserving space in the buffer based on content length for optimal performance.
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 71.57% 71.76% +0.19%
==========================================
Files 60 60
Lines 3261 3287 +26
==========================================
+ Hits 2334 2359 +25
- Misses 927 928 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
bytesmethod toReadResponseExtandAsyncReadResponseExt. These convenience methods are similar to thetextmethods without text decoding involved. These can make some uses more concise, and also take care of reserving space in the buffer based on content length for optimal performance.